Skip to content
Snippets Groups Projects
Commit b28d2eab authored by Torsten Oppermann's avatar Torsten Oppermann
Browse files

[TASK] Some code review

parent 863c48e6
No related branches found
No related tags found
1 merge request!5Feature 5 2 0
...@@ -375,16 +375,13 @@ class OverviewController extends AbstractController { ...@@ -375,16 +375,13 @@ class OverviewController extends AbstractController {
* Renders the news in a paginated list * Renders the news in a paginated list
* *
* @param array $newsMetaData * @param array $newsMetaData
* @param array $newsFilter * @param array|null $newsFilter
* @return void * @return void
* @throws \InvalidArgumentException * @throws \InvalidArgumentException
* @throws \TYPO3\CMS\Extbase\Persistence\Exception\InvalidQueryException * @throws \TYPO3\CMS\Extbase\Persistence\Exception\InvalidQueryException
* @throws \TYPO3\CMS\Extbase\Mvc\Exception\NoSuchArgumentException
*/ */
protected function overviewWithoutCategoriesAction(array $newsMetaData = [], array $newsFilter = NULL) { protected function overviewWithoutCategoriesAction(array $newsMetaData = [], array $newsFilter = NULL) {
if (empty($newsFilter)) {
$newsFilter = $this->request->getArguments()['newsFilter'];
}
// remember selection of the filter values, if any // remember selection of the filter values, if any
$selectedTag = $this->tagRepository->findByUid((int) $newsFilter['tag']); $selectedTag = $this->tagRepository->findByUid((int) $newsFilter['tag']);
$selectedCategory = $this->categoryRepository->findByUid((int) $newsFilter['category']); $selectedCategory = $this->categoryRepository->findByUid((int) $newsFilter['category']);
...@@ -454,7 +451,7 @@ class OverviewController extends AbstractController { ...@@ -454,7 +451,7 @@ class OverviewController extends AbstractController {
$nextPage = $currentPageBrowserPage + 1; $nextPage = $currentPageBrowserPage + 1;
if ($nextPage <= $numberOfPages) { if ($nextPage <= $numberOfPages) {
GeneralUtility::_GETset(['tx_sgnews_pagebrowser' => ['currentPage' => $nextPage]]); GeneralUtility::_GETset(['tx_sgnews_pagebrowser' => ['currentPage' => $nextPage]]);
$this->overviewWithoutCategoriesAction($newsMetaData, $this->request->getArguments()['newsFilter']); $this->overviewWithoutCategoriesAction($newsMetaData, $newsFilter);
return; return;
} }
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment