From b28d2eab9a63917b96f8efaaa9d5f1b08f24082b Mon Sep 17 00:00:00 2001
From: Torsten Oppermann <torsten@sgalinski.de>
Date: Fri, 15 Dec 2017 12:33:06 +0100
Subject: [PATCH] [TASK] Some code review
---
Classes/Controller/OverviewController.php | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/Classes/Controller/OverviewController.php b/Classes/Controller/OverviewController.php
index 0765b3a..3d88620 100644
--- a/Classes/Controller/OverviewController.php
+++ b/Classes/Controller/OverviewController.php
@@ -375,16 +375,13 @@ class OverviewController extends AbstractController {
* Renders the news in a paginated list
*
* @param array $newsMetaData
- * @param array $newsFilter
+ * @param array|null $newsFilter
* @return void
* @throws \InvalidArgumentException
* @throws \TYPO3\CMS\Extbase\Persistence\Exception\InvalidQueryException
+ * @throws \TYPO3\CMS\Extbase\Mvc\Exception\NoSuchArgumentException
*/
protected function overviewWithoutCategoriesAction(array $newsMetaData = [], array $newsFilter = NULL) {
- if (empty($newsFilter)) {
- $newsFilter = $this->request->getArguments()['newsFilter'];
- }
-
// remember selection of the filter values, if any
$selectedTag = $this->tagRepository->findByUid((int) $newsFilter['tag']);
$selectedCategory = $this->categoryRepository->findByUid((int) $newsFilter['category']);
@@ -454,7 +451,7 @@ class OverviewController extends AbstractController {
$nextPage = $currentPageBrowserPage + 1;
if ($nextPage <= $numberOfPages) {
GeneralUtility::_GETset(['tx_sgnews_pagebrowser' => ['currentPage' => $nextPage]]);
- $this->overviewWithoutCategoriesAction($newsMetaData, $this->request->getArguments()['newsFilter']);
+ $this->overviewWithoutCategoriesAction($newsMetaData, $newsFilter);
return;
}
}
--
GitLab