Skip to content
Snippets Groups Projects
Commit 9b7ac249 authored by Johannes Kreiner's avatar Johannes Kreiner Committed by Kevin von Spiczak
Browse files

[TASK] Improve BE UX

parent 2cb0a560
No related branches found
No related tags found
1 merge request!4[WIP] add 2 new fields to control maxTitleChars & maxDescChars
...@@ -53,6 +53,7 @@ class PreviewService { ...@@ -53,6 +53,7 @@ class PreviewService {
'thumbnailType' => $this->passVDefOnKeyToTemplate($pluginConfiguration, 'settings.thumbnailType'), 'thumbnailType' => $this->passVDefOnKeyToTemplate($pluginConfiguration, 'settings.thumbnailType'),
'thumbnailImagesCount' => $this->passVDefOnKeyToTemplate($pluginConfiguration, 'settings.thumbnailImages'), 'thumbnailImagesCount' => $this->passVDefOnKeyToTemplate($pluginConfiguration, 'settings.thumbnailImages'),
'showApiResult' => $this->passVDefOnKeyToTemplate($pluginConfiguration, 'settings.showApiResult'), 'showApiResult' => $this->passVDefOnKeyToTemplate($pluginConfiguration, 'settings.showApiResult'),
'urlParameters' => $this->passVDefOnKeyToTemplate($pluginConfiguration, 'settings.urlParameters'),
]; ];
$view->assign('data', $templateData); $view->assign('data', $templateData);
......
...@@ -75,4 +75,5 @@ Requires `img-src https://i.vimeocdn.com;`, `script-src https://player.vimeo.com ...@@ -75,4 +75,5 @@ Requires `img-src https://i.vimeocdn.com;`, `script-src https://player.vimeo.com
### Known issues ### Known issues
- Additional URL parameters won't get passed to the iframe inside the lightbox, this is seemingly caused by Plyr's integration of the Vimeo API - Additional URL parameters won't get passed to the iframe inside the lightbox, this is seemingly caused by Plyr's integration of the Vimeo API
- See also https://github.com/sampotts/plyr/issues/218#issuecomment-849942139
- Workaround: disable the lightbox for your Vimeo video - Workaround: disable the lightbox for your Vimeo video
...@@ -142,8 +142,8 @@ ...@@ -142,8 +142,8 @@
<target><![CDATA[Weniger]]></target> <target><![CDATA[Weniger]]></target>
</trans-unit> </trans-unit>
<trans-unit id="flexform.urlParameters" approved="yes"> <trans-unit id="flexform.urlParameters" approved="yes">
<source><![CDATA[Additional URL parameters]]></source> <source><![CDATA[Additional URL parameters (only without Lightbox)]]></source>
<target><![CDATA[Zusätzliche URL-Parameter]]></target> <target><![CDATA[Zusätzliche URL-Parameter (nur ohne Lightbox)]]></target>
</trans-unit> </trans-unit>
<trans-unit id="flexform.urlParameters.description" approved="yes"> <trans-unit id="flexform.urlParameters.description" approved="yes">
<source><![CDATA[See https://vimeo.zendesk.com/hc/en-us/articles/360001494447-Player-parameters-overview]]></source> <source><![CDATA[See https://vimeo.zendesk.com/hc/en-us/articles/360001494447-Player-parameters-overview]]></source>
......
...@@ -105,7 +105,7 @@ ...@@ -105,7 +105,7 @@
<source><![CDATA[Vimeo]]></source> <source><![CDATA[Vimeo]]></source>
</trans-unit> </trans-unit>
<trans-unit id="flexform.urlParameters"> <trans-unit id="flexform.urlParameters">
<source><![CDATA[Additional URL parameters]]></source> <source><![CDATA[Additional URL parameters (only without Lightbox)]]></source>
</trans-unit> </trans-unit>
<trans-unit id="flexform.urlParameters.description"> <trans-unit id="flexform.urlParameters.description">
<source><![CDATA[See https://vimeo.zendesk.com/hc/en-us/articles/360001494447-Player-parameters-overview]]></source> <source><![CDATA[See https://vimeo.zendesk.com/hc/en-us/articles/360001494447-Player-parameters-overview]]></source>
......
...@@ -95,6 +95,15 @@ ...@@ -95,6 +95,15 @@
</td> </td>
</tr> </tr>
</f:if> </f:if>
<tr>
<th scope="row">
<f:translate key="flexform.urlParameters" extensionName="SgYoutube"/>
</th>
<td>
{data.urlParameters}
</td>
</tr>
</tbody> </tbody>
</table> </table>
</be:link.editRecord> </be:link.editRecord>
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment