[TASK] cleanup

Classes/Service/ConfigurationService.php

@@ -51,14 +51,16 @@ class ConfigurationService implements SingletonInterface {
 	 * @throws InvalidConfigurationTypeException
 	 * @return string
 	 */
-	public function getConfiguration($key, $settings): string {
+	public function getConfiguration($key, array $settings): string {
 		if (!$this->tsConfig) {
 			$configurationManager = GeneralUtility::makeInstance(ConfigurationManager::class);
 			$this->tsConfig = $configurationManager->getConfiguration(ConfigurationManagerInterface::CONFIGURATION_TYPE_FULL_TYPOSCRIPT);
 		}
 		if ($settings[$key] === 'typoscript') {
-			return $this->tsConfig['plugin.']['tx_sgnews.']['settings.'][$key];
+			$setting = $this->tsConfig['plugin.']['tx_sgnews.']['settings.'][$key];
+		} else {
+			$setting = $settings[$key];
 		}
-		return $settings[$key];
+		return $setting;
 	}
 }