[TASK] Code cleanups

Classes/Service/BackendService.php

@@ -102,10 +102,9 @@ class BackendService {
 	/**
 	 * Retrieves the next site root in the page hierarchy from the current page
 	 *
-	 * @param $currentPid
 	 * @return int
 	 */
-	public static function getSiteRoot($currentPid) {
+	public static function getSiteRoot() {
 		$rootLine = BackendUtility::BEgetRootLine((int) GeneralUtility::_GP('id'));
 		$siteRoot = [];
 

Classes/Service/FormhandlerFinisherService.php

@@ -69,6 +69,8 @@ class FormhandlerFinisherService extends AbstractFinisher {
 	 *  Needed to hook into Formhandler
 	 *
 	 * @return array $gp
+	 * @throws \TYPO3\CMS\Extbase\Persistence\Exception\IllegalObjectTypeException
+	 * @throws \InvalidArgumentException
 	 */
 	public function process() {
 		if (!isset($this->settings['to_address'])) {
@@ -92,12 +94,4 @@ class FormhandlerFinisherService extends AbstractFinisher {
 
 		return $this->gp;
 	}
-
-	/**
-	 * Needed to hook into Formhandler
-	 * simply returns true
-	 */
-	public function validateConfig() {
-		parent::validateConfig();
-	}
 }

Classes/Service/TypoScriptSettingsService.php

@@ -60,11 +60,11 @@ class TypoScriptSettingsService implements SingletonInterface {
 			$_POST['id'] = $pageId;
 
 			/** @var TypoScriptService $typoScriptService */
-			$class = 'TYPO3\CMS\Extbase\Service\TypoScriptService';
+			$class = TypoScriptService::class;
 			$typoScriptService = $this->objectManager->get($class);
 
 			/** @var BackendConfigurationManager $configurationManager */
-			$class = 'TYPO3\CMS\Extbase\Configuration\BackendConfigurationManager';
+			$class = BackendConfigurationManager::class;
 			$configurationManager = $this->objectManager->get($class);
 
 			self::$typoScriptCache[$extensionKey . $pageId] = $typoScriptService->convertTypoScriptArrayToPlainArray(