[TASK] More refactorings, moving code from controller to service class

Classes/Controller/MailController.php

@@ -156,32 +156,16 @@ class MailController extends ActionController {
 				$registerArray[$selectedExtension][$selectedTemplate]['subject'][$selectedLanguages['right']]
 			);
 		} else {
-			$langFile = GeneralUtility::readLLfile(
-				'EXT:' . $selectedExtension . '/Resources/Private/Language/locallang.xlf', $selectedLanguages['left']
-			);
-
-			$translatedSubject = $langFile['default'][$subject][0]['target'];
-			if ($langFile[$selectedLanguages['left']][$subject][0]) {
-				$translatedSubject = $langFile[$selectedLanguages['left']][$subject][0]['target'];
-			}
+			$translatedSubjects = BackendService::getTranslatedTemplateSubject($subject, $selectedExtension, $selectedLanguages);
 
 			$this->view->assign(
 				'subjectLeft', $selectedTemplates['left'] !== NULL ? $selectedTemplates['left']->getSubject() :
-				$translatedSubject
+				$translatedSubjects['left']
 			);
 
-			$langFile = GeneralUtility::readLLfile(
-				'EXT:' . $selectedExtension . '/Resources/Private/Language/locallang.xlf', $selectedLanguages['right']
-			);
-
-			$translatedSubject = $langFile['default'][$subject][0]['target'];
-			if ($langFile[$selectedLanguages['left']][$subject][0][$subject]) {
-				$translatedSubject = $langFile[$selectedLanguages['right']][$subject][0]['target'];
-			}
-
 			$this->view->assign(
 				'subjectRight', $selectedTemplates['right'] !== NULL ? $selectedTemplates['right']->getSubject() :
-				$translatedSubject
+				$translatedSubjects['right']
 			);
 		}
 

Classes/Service/BackendService.php

@@ -212,4 +212,36 @@ class BackendService {
 
 		return $selectedTemplates;
 	}
+
+	/**
+	 * Get the translated subjects for the selected mail templates
+	 *
+	 * @param $subject
+	 * @param $selectedExtension
+	 * @param $selectedLanguages
+	 * @return array
+	 */
+	public static function getTranslatedTemplateSubject($subject, $selectedExtension, $selectedLanguages) {
+		$translatedSubjects = [];
+
+		$langFile = GeneralUtility::readLLfile(
+			'EXT:' . $selectedExtension . '/Resources/Private/Language/locallang.xlf', $selectedLanguages['left']
+		);
+		$translatedSubjectLeft = $langFile['default'][$subject][0]['target'];
+		if ($langFile[$selectedLanguages['left']][$subject][0]) {
+			$translatedSubjectLeft = $langFile[$selectedLanguages['left']][$subject][0]['target'];
+		}
+		$translatedSubjects['left'] = $translatedSubjectLeft;
+
+		$langFile = GeneralUtility::readLLfile(
+			'EXT:' . $selectedExtension . '/Resources/Private/Language/locallang.xlf', $selectedLanguages['right']
+		);
+		$translatedSubjectRight = $langFile['default'][$subject][0]['target'];
+		if ($langFile[$selectedLanguages['right']][$subject][0]) {
+			$translatedSubjectRight = $langFile[$selectedLanguages['right']][$subject][0]['target'];
+		}
+		$translatedSubjects['right'] = $translatedSubjectRight;
+
+		return $translatedSubjects;
+	}
 }