[FEATURE] save filters in session

https://trello.com/c/PtW89d14/3338-extsgmail-restore-used-filters-after-going-back-eg-inside-the-mail-queue-store-them-inside-a-php-session-also-check-all-other-ba

Classes/Controller/BackendController.php

@@ -87,76 +87,70 @@ class BackendController extends ActionController {
 	 * @return void
 	 */
 	public function indexAction(array $filters = []): void {
-		try {
-			$pageUid = (int) GeneralUtility::_GP('id');
-			/** @var BackendUserAuthentication $backendUser */
-			$backendUser = $GLOBALS['BE_USER'];
-			if ($filters === []) {
-				$filters = $backendUser->getModuleData('tools_beuser/index.php/web_SgJobsBackend_filters', 'ses') ?: [];
-			} else {
-				$backendUser->pushModuleData('tools_beuser/index.php/web_SgJobsBackend_filters', $filters);
-			}
-			// create docheader + buttons
-			$pageInfo = BackendUtility::readPageAccess($pageUid, $GLOBALS['BE_USER']->getPagePermsClause(1));
-			if ($pageInfo === FALSE) {
-				$pageInfo = ['uid' => $pageUid];
-			}
-
-			$this->docHeaderComponent = GeneralUtility::makeInstance(DocHeaderComponent::class);
-			$this->docHeaderComponent->setMetaInformation($pageInfo);
-			BackendService::makeButtons($this->docHeaderComponent, $this->request);
-			$this->view->assign('docHeader', $this->docHeaderComponent->docHeaderContent());
-			// get all jobs
-			/** @var ObjectStorage $jobs */
-			$jobs = $this->jobRepository->findBackendJobs($pageUid, $filters);
-
-			$totalJobCount = \count($jobs);
-
-			$this->view->assign('pages', BackendService::getPagesWithJobRecords());
-			$this->view->assign('pageUid', $pageUid);
-
-			$sortingData = [];
-			if ($GLOBALS['TYPO3_CONF_VARS']['EXTENSIONS']['sg_jobs']['allowManualSorting'] && count($filters) <= 0) {
-
-				/**
-				 *
-				 * Somehow the pId is changed so data gets lost.
-				 *
-				 *
-				 * $previousUid = 0;
-				 * $sortingData = [];
-				 * foreach ($jobs as $job) {
-				 * if ($previousUid) {
-				 * $sortingData['prev'][$job->getUid()] = $previousUid;
-				 * $sortingData['next'][$previousUid] = $job->getUid();
-				 * }
-				 * $previousUid = $job->getUid();
-				 * }
-				 */
-				$this->view->assign('manualSortingDestroysEverything', TRUE);
-			}
-
-			$this->view->assign('sortingData', $sortingData);
-
-			// get all Locations
-			/** @noinspection PhpUndefinedMethodInspection */
-			/** @var QueryResultInterface $companies */
-			$companies = $this->companyRepository->findByPid($pageUid);
-			$this->view->assign('locationOptions', $companies);
-			if ($totalJobCount || $companies->count()) {
-				$this->view->assign('jobs', $jobs);
-				$this->view->assign('filters', $filters);
-			} else {
-				$this->view->assign('noRecords', 1);
-				$this->view->assign('isAdmin', $GLOBALS['BE_USER']->isAdmin());
-				$this->addFlashMessage(
-					LocalizationUtility::translate('backend.notice.noRecords', 'SgJobs'), '', FlashMessage::INFO
-				);
-			}
-
-		} catch (\Exception $exception) {
-			// check for NULL value in view and render an error message
-			$this->view->assign('docHeader', NULL);
+		$pageUid = (int) GeneralUtility::_GP('id');
+
+		/** @var BackendUserAuthentication $backendUser */
+		$backendUser = $GLOBALS['BE_USER'];
+		if ($filters === []) {
+			$filters = $backendUser->getModuleData('tools_beuser/index.php/web_SgJobsBackend_filters', 'ses') ?: [];
+		} else {
+			$backendUser->pushModuleData('tools_beuser/index.php/web_SgJobsBackend_filters', $filters);
+		}
+
+		// create docheader + buttons
+		$pageInfo = BackendUtility::readPageAccess($pageUid, $GLOBALS['BE_USER']->getPagePermsClause(1));
+		if ($pageInfo === FALSE) {
+			$pageInfo = ['uid' => $pageUid];
+		}
+
+		$this->docHeaderComponent = GeneralUtility::makeInstance(DocHeaderComponent::class);
+		$this->docHeaderComponent->setMetaInformation($pageInfo);
+		BackendService::makeButtons($this->docHeaderComponent, $this->request);
+		$this->view->assign('docHeader', $this->docHeaderComponent->docHeaderContent());
+
+		$this->view->assign('pageUid', $pageUid);
+		$this->view->assign('pages', BackendService::getPagesWithJobRecords());
+
+		$sortingData = [];
+		if ($GLOBALS['TYPO3_CONF_VARS']['EXTENSIONS']['sg_jobs']['allowManualSorting'] && count($filters) <= 0) {
+			/**
+			 * Somehow the pId is changed so data gets lost.
+			 *
+			 *
+			 * $previousUid = 0;
+			 * $sortingData = [];
+			 * foreach ($jobs as $job) {
+			 * if ($previousUid) {
+			 * $sortingData['prev'][$job->getUid()] = $previousUid;
+			 * $sortingData['next'][$previousUid] = $job->getUid();
+			 * }
+			 * $previousUid = $job->getUid();
+			 * }
+			 */
+			$this->view->assign('manualSortingDestroysEverything', TRUE);
+		}
+		$this->view->assign('sortingData', $sortingData);
+
+		/** @var ObjectStorage $jobs */
+		$jobs = $this->jobRepository->findBackendJobs($pageUid, $filters);
+		$totalJobCount = \count($jobs);
+
+		// get all Locations
+		/** @noinspection PhpUndefinedMethodInspection */
+		/** @var QueryResultInterface $companies */
+		$companies = $this->companyRepository->findByPid($pageUid);
+		$this->view->assign('locationOptions', $companies);
+
+		$this->view->assign('isAdmin', $GLOBALS['BE_USER']->isAdmin());
+		$this->view->assign('filters', $filters);
+		$this->view->assign('jobs', $jobs);
+		if (!$totalJobCount && $pageUid) {
+			// clear previously set filters again,
+			// without this, the user would be stuck without filters and just the flash message
+			$backendUser->pushModuleData('tools_beuser/index.php/web_SgJobsBackend_filters', []);
+			$this->addFlashMessage(
+				LocalizationUtility::translate('backend.notice.noRecords', 'SgJobs'), '', FlashMessage::INFO
+			);
 		}
 	}
 }