[TASK] Add support for global allowManualSorting flag

Classes/Controller/BackendController.php

@@ -148,7 +148,7 @@ class BackendController extends ActionController {
 		$this->view->assign('pagination', $pagination);
 		$totalJobCount = \count($jobs);
 		$this->view->assign('totalJobCount', $totalJobCount);
-
+		$isManualSortingAllowed = $GLOBALS['TYPO3_CONF_VARS']['EXTENSIONS']['sg_jobs']['allowManualSorting'];
 		// get all Locations
 		/** @noinspection PhpUndefinedMethodInspection */
 		/** @var QueryResultInterface $companies */
@@ -156,6 +156,7 @@ class BackendController extends ActionController {
 		$this->view->assign('locationOptions', $companies);
 
 		$this->view->assign('isAdmin', $GLOBALS['BE_USER']->isAdmin());
+		$this->view->assign('isManualSortingAllowed', $isManualSortingAllowed);
 		$this->view->assign('filters', $filters);
 		$this->view->assign('jobs', $jobs);
 		if (!$totalJobCount && $pageUid) {

Classes/ViewHelpers/Backend/ControlViewHelper.php

@@ -46,6 +46,7 @@ class ControlViewHelper extends AbstractViewHelper {
 		$this->registerArgument('row', 'array', 'The row of the record', TRUE);
 		$this->registerArgument('allItems', 'array', 'allRows', FALSE);
 		$this->registerArgument('iter', 'array', 'current Iterator', FALSE);
+		$this->registerArgument('isManualSortingAllowed', 'bool', 'global flag', FALSE);
 	}
 
 	/**
@@ -77,45 +78,52 @@ class ControlViewHelper extends AbstractViewHelper {
 		$languageService = GeneralUtility::makeInstance(\TYPO3\CMS\Core\Localization\LanguageService::class);
 		$languageService->includeLLFile('EXT:backend/Resources/Private/Language/locallang_alt_doc.xlf');
 
-		// DatabaseRecordList has a $prevPrevUid, which might track back a page. We wont do that, 1st+last record are always
-		// not sortable in one direction
-		$uidPrev = false;
-		$uidNext = false;
-		$iterator = $this->arguments['iter'];
-		if (!$iterator['isFirst'] && $iterator['index'] !== 1){
-			$uidPrev = '-'.$this->arguments['allItems'][$iterator['index'] - 2]['uid'];
-		}
-		if ($iterator['index'] === 1){
-			$uidPrev = $row['pid'];
-		}
-		if (!$iterator['isLast']){
-			$uidNext = '-'.$this->arguments['allItems'][$iterator['index'] + 1]['uid'];
-		}
+		// manual sorting only makes sence if it is allowed, we got allItems + current Iterator
+		if (array_key_exists('isManualSortingAllowed', $this->arguments)
+			&& array_key_exists('allItems', $this->arguments)
+			&& array_key_exists('iter', $this->arguments)
+			&&  $this->arguments['isManualSortingAllowed']
+		) {
+			// DatabaseRecordList has a $prevPrevUid, which might track back a page. We wont do that, 1st+last record are always
+			// not sortable in one direction
+			$uidPrev = FALSE;
+			$uidNext = FALSE;
+			$iterator = $this->arguments['iter'];
+			if (!$iterator['isFirst'] && $iterator['index'] !== 1) {
+				$uidPrev = '-' . $this->arguments['allItems'][$iterator['index'] - 2]['uid'];
+			}
+			if ($iterator['index'] === 1) {
+				$uidPrev = $row['pid'];
+			}
+			if (!$iterator['isLast']) {
+				$uidNext = '-' . $this->arguments['allItems'][$iterator['index'] + 1]['uid'];
+			}
 
-		$newCurrentTableArr = [
-			'prev' => [
-				$row['uid'] => $uidPrev
-			],
-			'next' => [
-				$row['uid'] => $uidNext
-			]
-		];
-		if (!$uidPrev) {
-			$newCurrentTableArr = [
-				'next' => [
-					$row['uid'] => $uidNext
-				]
-			];
-		}
-		if (!$uidNext) {
 			$newCurrentTableArr = [
 				'prev' => [
 					$row['uid'] => $uidPrev
+				],
+				'next' => [
+					$row['uid'] => $uidNext
 				]
 			];
+			if (!$uidPrev) {
+				$newCurrentTableArr = [
+					'next' => [
+						$row['uid'] => $uidNext
+					]
+				];
+			}
+			if (!$uidNext) {
+				$newCurrentTableArr = [
+					'prev' => [
+						$row['uid'] => $uidPrev
+					]
+				];
+			}
+			$databaseRecordList->id = $row['pid'];
+			$databaseRecordList->currentTable = $newCurrentTableArr;
 		}
-		$databaseRecordList->id = $row['pid'];
-		$databaseRecordList->currentTable = $newCurrentTableArr;
 
 		return $databaseRecordList->makeControl($table, $row);
 	}

Resources/Private/Backend/Templates/Index.html

@@ -50,7 +50,7 @@
 												</be:link.editRecord>
 											</td>
 											<td nowrap="nowrap" class="col-control">
-												<f:format.raw><sg:backend.control table="tx_sgjobs_domain_model_job" row="{job}" allItems="{paginator.paginatedItems}" iter="{iter}" /></f:format.raw>
+												<f:format.raw><sg:backend.control table="tx_sgjobs_domain_model_job" row="{job}" allItems="{paginator.paginatedItems}" iter="{iter}" isManualSortingAllowed="{isManualSortingAllowed}" /></f:format.raw>
 											</td>
 										</tr>
 									</f:for>