[BUGFIX] Fix default allowedFileExtensions settings and applyForm redirect on validation errors

Classes/Controller/JoblistController.php

@@ -287,23 +287,15 @@ class JoblistController extends ActionController {
 		$propertyMappingConfiguration = $this->arguments->getArgument('applyData')->getPropertyMappingConfiguration();
 		$propertyMappingConfiguration->forProperty('job')->allowAllProperties();
 
-		$typeConverter1 = $this->objectManager->get(UploadedFileReferenceConverter::class);
-		$typeConverter1->setAllowedFileExtensions($this->settings['allowedFileExtensions']);
-		$typeConverter1->setUploadFolder('1:/JobApplication/temp/' . $uniqueFolderName);
-		$typeConverter1->setTargetUploadFileName('coverLetter');
-		$propertyMappingConfiguration->forProperty('coverLetter')->setTypeConverter($typeConverter1);
-
-		$typeConverter2 = $this->objectManager->get(UploadedFileReferenceConverter::class);
-		$typeConverter2->setAllowedFileExtensions($this->settings['allowedFileExtensions']);
-		$typeConverter2->setUploadFolder('1:/JobApplication/temp/' . $uniqueFolderName);
-		$typeConverter2->setTargetUploadFileName('cv');
-		$propertyMappingConfiguration->forProperty('cv')->setTypeConverter($typeConverter2);
-
-		$typeConverter3 = $this->objectManager->get(UploadedFileReferenceConverter::class);
-		$typeConverter3->setAllowedFileExtensions($this->settings['allowedFileExtensions']);
-		$typeConverter3->setUploadFolder('1:/JobApplication/temp/' . $uniqueFolderName);
-		$typeConverter3->setTargetUploadFileName('certificate');
-		$propertyMappingConfiguration->forProperty('certificate')->setTypeConverter($typeConverter3);
+		foreach (['coverLetter', 'cv', 'certificate'] as $property) {
+			$typeConverter = $this->objectManager->get(UploadedFileReferenceConverter::class);
+			$typeConverter->setAllowedFileExtensions(
+				$this->settings['allowedFileExtensions'] ?? $GLOBALS['TYPO3_CONF_VARS']['GFX']['imagefile_ext']
+			);
+			$typeConverter->setUploadFolder('1:/JobApplication/temp/' . $uniqueFolderName);
+			$typeConverter->setTargetUploadFileName($property);
+			$propertyMappingConfiguration->forProperty($property)->setTypeConverter($typeConverter);
+		}
 	}
 
 	/**
@@ -418,7 +410,7 @@ class JoblistController extends ActionController {
 			$this->request->setArgument('folderName', $folderName);
 			$this->forward(
 				'applyForm', NULL, NULL,
-				['applyData' => $applyData, 'error' => $exception->getMessage(), 'uid' => $jobId]
+				['applyData' => $applyData, 'error' => $exception->getMessage(), 'jobId' => $jobId]
 			);
 		}
 	}

Resources/Private/Templates/Joblist/ApplyForm.html

@@ -25,7 +25,7 @@
 					<f:form.hidden property="company" value="{job.company.uid}" />
 				</f:then>
 			</f:if>
-			<input type="hidden" name="tx_sgjobs_jobapplication[folderName]" value="{folderName}" />
+			<f:form.hidden name="folderName" value="{folderName}" />
 
 			<f:comment><!-- To output all validation errors
 				<f:form.validationResults>