[TASK] Use collections only if necessary

Classes/Domain/Model/JobApplication.php

@@ -119,13 +119,13 @@ class JobApplication extends AbstractEntity {
 	protected $email = '';
 
 	/**
-	 * @var \TYPO3\CMS\Extbase\Persistence\ObjectStorage $coverLetter
+	 * @var \TYPO3\CMS\Extbase\Domain\Model\FileReference $coverLetter
 	 *
 	 */
 	protected $coverLetter;
 
 	/**
-	 * @var \TYPO3\CMS\Extbase\Persistence\ObjectStorage $cv
+	 * @var \TYPO3\CMS\Extbase\Domain\Model\FileReference $cv
 	 *
 	 */
 	protected $cv;
@@ -145,8 +145,6 @@ class JobApplication extends AbstractEntity {
 	 * JobApplication constructor.
 	 */
 	public function __construct() {
-		$this->coverLetter = new ObjectStorage();
-		$this->cv = new ObjectStorage();
 		$this->certificates = new ObjectStorage();
 	}
 
@@ -347,30 +345,30 @@ class JobApplication extends AbstractEntity {
 	}
 
 	/**
-	 * @return \TYPO3\CMS\Extbase\Persistence\ObjectStorage<\TYPO3\CMS\Extbase\Domain\Model\FileReference>
+	 * @return \TYPO3\CMS\Extbase\Domain\Model\FileReference
 	 */
 	public function getCoverLetter() {
 		return $this->coverLetter;
 	}
 
 	/**
-	 * @param \TYPO3\CMS\Extbase\Persistence\ObjectStorage<\TYPO3\CMS\Extbase\Domain\Model\FileReference> $coverLetter
+	 * @param \TYPO3\CMS\Extbase\Domain\Model\FileReference $coverLetter
 	 */
-	public function setCoverLetter(ObjectStorage $coverLetter) {
+	public function setCoverLetter(\TYPO3\CMS\Extbase\Domain\Model\FileReference $coverLetter) {
 		$this->coverLetter = $coverLetter;
 	}
 
 	/**
-	 * @return \TYPO3\CMS\Extbase\Persistence\ObjectStorage<\TYPO3\CMS\Extbase\Domain\Model\FileReference>
+	 * @return \TYPO3\CMS\Extbase\Domain\Model\FileReference
 	 */
 	public function getCv() {
 		return $this->cv;
 	}
 
 	/**
-	 * @param \TYPO3\CMS\Extbase\Persistence\ObjectStorage<\TYPO3\CMS\Extbase\Domain\Model\FileReference> $cv
+	 * @param \TYPO3\CMS\Extbase\Domain\Model\FileReference $cv
 	 */
-	public function setCV(ObjectStorage $cv) {
+	public function setCV(\TYPO3\CMS\Extbase\Domain\Model\FileReference $cv) {
 		$this->cv = $cv;
 	}
 
@@ -382,7 +380,7 @@ class JobApplication extends AbstractEntity {
 	}
 
 	/**
-	 * @param \TYPO3\CMS\Extbase\Persistence\ObjectStorage<\TYPO3\CMS\Extbase\Domain\Model\FileReference> $certificates
+	 * @param \TYPO3\CMS\Extbase\Persistence\ObjectStorage $certificates
 	 */
 	public function setCertificates(ObjectStorage $certificates) {
 		$this->certificates = $certificates;

Resources/Private/Templates/Joblist/ApplyForm.html

@@ -180,7 +180,6 @@
 				<f:translate key="frontend.apply.allowed_file_extensions" />{allowedFileExtensions}
 			</label>
 			<h:form.upload property="coverLetter" id="apply-cover-letter" additionalAttributes="{accept: '{allowedMimeTypes}'}" />
-			<f:comment><h:form.upload property="coverLetter.0">test</h:form.upload></f:comment>
 			<f:for each="{uploadedFiles.coverLetter}" as="file">
 				<div class="sg-jobs-uploaded-file">
 					<span class="filename">{file.name}</span>
@@ -188,24 +187,6 @@
 				</div>
 			</f:for>
 
-
-		<f:comment>
-			<h:form.upload property="image" >
-				<f:if condition="{resource}">
-					<f:image image="{resource}" alt="" width="50"/>
-				</f:if>
-			</h:form.upload><br />
-		<label for="image_collection">
-			<f:translate key="tx_uploadexample_domain_model_example.image_collection" />
-		</label><br />
-			<h:form.upload property="imageCollection.0">
-				<f:if condition="{resource}">
-					<f:image image="{resource}" alt="" width="50"/>
-				</f:if>
-			</h:form.upload>
-		</f:comment>
-
-
 			<f:form.validationResults for="applyData.coverLetter">
 				<f:for each="{validationResults.errors}" as="error">
 					<div class="sg-jobs-validation-error">
@@ -241,7 +222,7 @@
 				<f:translate key="frontend.apply.certificates" />
 				<f:translate key="frontend.apply.allowed_file_extensions" />{allowedFileExtensions}
 			</label>
-			<h:form.upload multiple="true" property="certificates" id="apply-certificates" additionalAttributes="{accept: '{allowedMimeTypes}'}" />
+			<h:form.upload multiple="true" property="certificates.0" id="apply-certificates" additionalAttributes="{accept: '{allowedMimeTypes}'}" />
 			<f:for each="{uploadedFiles.certificates}" as="file">
 				<div class="sg-jobs-uploaded-file">
 					<span class="filename">{file.name}</span>