Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • L lfeditor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 13
    • Issues 13
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • TYPO3
  • lfeditor
  • Merge requests
  • !19

[BUGFIX] Fix wrong encoding of CDATA markers

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Rémy DANIEL requested to merge dogawaf/lfeditor:cdata into master May 17, 2018
  • Overview 3
  • Commits 4
  • Changes 4

This PR fixes the encoding of CDATA markers when saving a translation.

For simplicity, strings are now always included in CDATA. Htmlentities are preserved (not re-encoded) if they were already in CDATA markers, and decoded if they were not.

So the XML file is always valid, and the strings are saved like they were seen in the backend form.

This will fix #18 (closed) and also #19 (closed)

Edited May 18, 2018 by Rémy DANIEL
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: cdata