Skip to content
Snippets Groups Projects
Commit 981b5515 authored by damjan's avatar damjan
Browse files

[BUGFIX] Optional arguments of actions must go at the end

parent 2afb8554
No related branches found
No related tags found
No related merge requests found
......@@ -88,13 +88,13 @@ class TsrefController extends \TYPO3\Flow\Mvc\Controller\ActionController {
* Adds a new type or saves changes in edited type.
*
* @param Type $theType
* @param string $typoScriptGroup
* @param boolean $editForm
* @param string $typo3Version
* @param string $typoScriptGroup
* @return void
*/
public function submitTypeAction( //TODO: Use session for typo3Version
Type $theType, $editForm = NULL, $typo3Version = TsrefRestService::TYPO3_CURRENT_VERSION_LABEL, $typoScriptGroup
Type $theType, $typoScriptGroup, $editForm = NULL, $typo3Version = TsrefRestService::TYPO3_CURRENT_VERSION_LABEL
) {
try {
$this->checkEditPermission($typoScriptGroup, $typo3Version);
......@@ -137,14 +137,13 @@ class TsrefController extends \TYPO3\Flow\Mvc\Controller\ActionController {
/**
* Prepares and opens the page for adding new / editing the type
*
* @param string $typoScriptGroup
* @param int $typeId
* @param string $typo3Version
* @param string $typoScriptGroup
* @return void
*/
public function editTypeAction(
$typeId = NULL, $typo3Version = TsrefRestService::TYPO3_CURRENT_VERSION_LABEL,
$typoScriptGroup
$typoScriptGroup, $typeId = NULL, $typo3Version = TsrefRestService::TYPO3_CURRENT_VERSION_LABEL
) { //TODO: Use session for typo3Version
$theType = new Type();
try {
......@@ -183,13 +182,13 @@ class TsrefController extends \TYPO3\Flow\Mvc\Controller\ActionController {
*
* @param Property $theProperty
* @param boolean $editForm
* @param string $typo3Version
* @param string $typoScriptGroup
* @param string $typo3Version
* @return void
*/
public function submitPropertyAction( //TODO: Use session for typo3Version
Property $theProperty, $editForm, $typo3Version = TsrefRestService::TYPO3_CURRENT_VERSION_LABEL,
$typoScriptGroup
Property $theProperty, $editForm, $typoScriptGroup,
$typo3Version = TsrefRestService::TYPO3_CURRENT_VERSION_LABEL
) {
$parentType = NULL;
try {
......@@ -233,14 +232,15 @@ class TsrefController extends \TYPO3\Flow\Mvc\Controller\ActionController {
* Prepares and opens the page for adding new / editing the property
*
* @param int $parentTypeId
* @param string $typoScriptGroup
* @param int $thePropertyId
* @param string $typo3Version
* @param string $typoScriptGroup
* @return void
*/
public function editPropertyAction( //TODO: Use session for typo3Version
$parentTypeId, $thePropertyId = NULL, $typo3Version = TsrefRestService::TYPO3_CURRENT_VERSION_LABEL,
$typoScriptGroup
$parentTypeId, $typoScriptGroup, $thePropertyId = NULL,
$typo3Version = TsrefRestService::TYPO3_CURRENT_VERSION_LABEL
) {
$parentType = NULL;
try {
......@@ -280,12 +280,12 @@ class TsrefController extends \TYPO3\Flow\Mvc\Controller\ActionController {
* Deletes type by $attributeId.
*
* @param int $attributeId
* @param string $typo3Version
* @param string $typoScriptGroup
* @param string $typo3Version
* @return void
*/
public function deleteTypeAction( //TODO: Use session for typo3Version
$attributeId, $typo3Version = TsrefRestService::TYPO3_CURRENT_VERSION_LABEL, $typoScriptGroup
$attributeId, $typoScriptGroup, $typo3Version = TsrefRestService::TYPO3_CURRENT_VERSION_LABEL
) {
try {
$this->checkEditPermission($typoScriptGroup, $typo3Version);
......@@ -308,14 +308,15 @@ class TsrefController extends \TYPO3\Flow\Mvc\Controller\ActionController {
* and then that type will be presented after deletion of the property.
*
* @param int $attributeId
* @param string $typoScriptGroup
* @param string $parentTypeUrlName
* @param string $typo3Version
* @param string $typoScriptGroup
* @return void
*/
public function deletePropertyAction( //TODO: Use session for typo3Version
$attributeId, $parentTypeUrlName = NULL, $typo3Version = TsrefRestService::TYPO3_CURRENT_VERSION_LABEL,
$typoScriptGroup
$attributeId, $typoScriptGroup, $parentTypeUrlName = NULL,
$typo3Version = TsrefRestService::TYPO3_CURRENT_VERSION_LABEL
) {
try {
$this->checkEditPermission($typoScriptGroup, $typo3Version, $parentTypeUrlName);
......@@ -350,12 +351,12 @@ class TsrefController extends \TYPO3\Flow\Mvc\Controller\ActionController {
/**
* Download action for tsref.xml
*
* @param string $typo3Version
* @param string $typoScriptGroup
* @param string $typo3Version
* @return void
*/
public function downloadTsrefAction(
$typo3Version = TsrefRestService::TYPO3_CURRENT_VERSION_LABEL, $typoScriptGroup
$typoScriptGroup, $typo3Version = TsrefRestService::TYPO3_CURRENT_VERSION_LABEL
) {
try {
$typo3DecodedVersion = $this->decodeTypo3Version($typo3Version);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment