From 042e2087e1d1e1878dd5c0d27e860f4410fd8ca8 Mon Sep 17 00:00:00 2001
From: Georgi Mateev <georgi.mateev@sgalinski.de>
Date: Fri, 2 Aug 2024 15:48:13 +0300
Subject: [PATCH] [BUGFIX] PHPStan code quality
---
Classes/Event/AfterFilterVideosEvent.php | 12 ++++--------
.../Event/AfterMapCustomThumbnailsEvent.php | 12 ++++--------
Classes/Event/AfterVimeoCallEvent.php | 12 ++++--------
Classes/Event/BeforeVimeoCallEvent.php | 18 ++++++------------
.../AfterFilterVideosEventListener.php | 6 ++----
.../AfterMapCustomThumbnailsEventListener.php | 6 ++----
.../AfterVimeoCallEventListener.php | 6 ++----
.../BeforeVimeoCallEventListener.php | 6 ++----
Classes/Service/VimeoService.php | 2 +-
9 files changed, 27 insertions(+), 53 deletions(-)
diff --git a/Classes/Event/AfterFilterVideosEvent.php b/Classes/Event/AfterFilterVideosEvent.php
index 2ccfe18..cbb5ec0 100644
--- a/Classes/Event/AfterFilterVideosEvent.php
+++ b/Classes/Event/AfterFilterVideosEvent.php
@@ -26,22 +26,18 @@
namespace SGalinski\SgVimeo\Event;
-final class AfterFilterVideosEvent
-{
+final class AfterFilterVideosEvent {
private array $response;
- public function __construct(array $response)
- {
+ public function __construct(array $response) {
$this->response = $response;
}
- public function getResponse(): array
- {
+ public function getResponse(): array {
return $this->response;
}
- public function setResponse(array $response): void
- {
+ public function setResponse(array $response): void {
$this->response = $response;
}
}
diff --git a/Classes/Event/AfterMapCustomThumbnailsEvent.php b/Classes/Event/AfterMapCustomThumbnailsEvent.php
index be9fb5e..a590202 100644
--- a/Classes/Event/AfterMapCustomThumbnailsEvent.php
+++ b/Classes/Event/AfterMapCustomThumbnailsEvent.php
@@ -26,22 +26,18 @@
namespace SGalinski\SgVimeo\Event;
-final class AfterMapCustomThumbnailsEvent
-{
+final class AfterMapCustomThumbnailsEvent {
private array $response;
- public function __construct(array $response)
- {
+ public function __construct(array $response) {
$this->response = $response;
}
- public function getResponse(): array
- {
+ public function getResponse(): array {
return $this->response;
}
- public function setResponse(array $response): void
- {
+ public function setResponse(array $response): void {
$this->response = $response;
}
}
diff --git a/Classes/Event/AfterVimeoCallEvent.php b/Classes/Event/AfterVimeoCallEvent.php
index e9be83c..72f4c7d 100644
--- a/Classes/Event/AfterVimeoCallEvent.php
+++ b/Classes/Event/AfterVimeoCallEvent.php
@@ -26,22 +26,18 @@
namespace SGalinski\SgVimeo\Event;
-final class AfterVimeoCallEvent
-{
+final class AfterVimeoCallEvent {
private array $response;
- public function __construct(array $response)
- {
+ public function __construct(array $response) {
$this->response = $response;
}
- public function getResponse(): array
- {
+ public function getResponse(): array {
return $this->response;
}
- public function setResponse(array $response): void
- {
+ public function setResponse(array $response): void {
$this->response = $response;
}
}
diff --git a/Classes/Event/BeforeVimeoCallEvent.php b/Classes/Event/BeforeVimeoCallEvent.php
index f5616a9..2eae7ab 100644
--- a/Classes/Event/BeforeVimeoCallEvent.php
+++ b/Classes/Event/BeforeVimeoCallEvent.php
@@ -26,35 +26,29 @@
namespace SGalinski\SgVimeo\Event;
-final class BeforeVimeoCallEvent
-{
+final class BeforeVimeoCallEvent {
private $id;
private $maxResultsWithFilters;
private string $apiKey;
- public function __construct($id, $maxResultsWithFilters)
- {
+ public function __construct($id, $maxResultsWithFilters) {
$this->id = $id;
$this->maxResultsWithFilters = $maxResultsWithFilters;
}
- public function getId()
- {
+ public function getId() {
return $this->id;
}
- public function setId($id): void
- {
+ public function setId($id): void {
$this->id = $id;
}
- public function getMaxResultsWithFilters()
- {
+ public function getMaxResultsWithFilters() {
return $this->maxResultsWithFilters;
}
- public function setMaxResultsWithFilters($maxResultsWithFilters): void
- {
+ public function setMaxResultsWithFilters($maxResultsWithFilters): void {
$this->maxResultsWithFilters = $maxResultsWithFilters;
}
}
diff --git a/Classes/EventListeners/AfterFilterVideosEventListener.php b/Classes/EventListeners/AfterFilterVideosEventListener.php
index b66fead..c87f9ab 100644
--- a/Classes/EventListeners/AfterFilterVideosEventListener.php
+++ b/Classes/EventListeners/AfterFilterVideosEventListener.php
@@ -27,10 +27,8 @@ namespace SGalinski\SgVimeo\EventListeners;
use SGalinski\SgVimeo\Event\AfterFilterVideosEvent;
-class AfterFilterVideosEventListener
-{
- public function __invoke(AfterFilterVideosEvent $event): void
- {
+class AfterFilterVideosEventListener {
+ public function __invoke(AfterFilterVideosEvent $event): void {
// Modify the response if needed
$response = $event->getResponse();
// Add some custom processing here
diff --git a/Classes/EventListeners/AfterMapCustomThumbnailsEventListener.php b/Classes/EventListeners/AfterMapCustomThumbnailsEventListener.php
index d00b026..b35ceaf 100644
--- a/Classes/EventListeners/AfterMapCustomThumbnailsEventListener.php
+++ b/Classes/EventListeners/AfterMapCustomThumbnailsEventListener.php
@@ -27,10 +27,8 @@ namespace SGalinski\SgVimeo\EventListeners;
use SGalinski\SgVimeo\Event\AfterMapCustomThumbnailsEvent;
-class AfterMapCustomThumbnailsEventListener
-{
- public function __invoke(AfterMapCustomThumbnailsEvent $event): void
- {
+class AfterMapCustomThumbnailsEventListener {
+ public function __invoke(AfterMapCustomThumbnailsEvent $event): void {
$response = $event->getResponse();
// Add a custom thumbnail URL
foreach ($response['items'] as $key => $item) {
diff --git a/Classes/EventListeners/AfterVimeoCallEventListener.php b/Classes/EventListeners/AfterVimeoCallEventListener.php
index b3d1652..8a6dd5b 100644
--- a/Classes/EventListeners/AfterVimeoCallEventListener.php
+++ b/Classes/EventListeners/AfterVimeoCallEventListener.php
@@ -27,10 +27,8 @@ namespace SGalinski\SgVimeo\EventListeners;
use SGalinski\SgVimeo\Event\AfterVimeoCallEvent;
-class AfterVimeoCallEventListener
-{
- public function __invoke(AfterVimeoCallEvent $event): void
- {
+class AfterVimeoCallEventListener {
+ public function __invoke(AfterVimeoCallEvent $event): void {
$response = $event->getResponse();
// Add custom data
$response['customData'] = 'This is some custom data';
diff --git a/Classes/EventListeners/BeforeVimeoCallEventListener.php b/Classes/EventListeners/BeforeVimeoCallEventListener.php
index ccc5fe5..2a8cd0e 100644
--- a/Classes/EventListeners/BeforeVimeoCallEventListener.php
+++ b/Classes/EventListeners/BeforeVimeoCallEventListener.php
@@ -30,10 +30,8 @@ use SGalinski\SgVimeo\Event\BeforeVimeoCallEvent;
/**
* Called before we call the Vimeo API
*/
-class BeforeVimeoCallEventListener
-{
- public function __invoke(BeforeVimeoCallEvent $event): void
- {
+class BeforeVimeoCallEventListener {
+ public function __invoke(BeforeVimeoCallEvent $event): void {
// Change the max results because we want to filter some more
$event->setMaxResultsWithFilters($event->getMaxResultsWithFilters() + 10);
}
diff --git a/Classes/Service/VimeoService.php b/Classes/Service/VimeoService.php
index b7eca72..30ff1e4 100644
--- a/Classes/Service/VimeoService.php
+++ b/Classes/Service/VimeoService.php
@@ -26,10 +26,10 @@
namespace SGalinski\SgVimeo\Service;
-use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
use Psr\Log\LoggerAwareInterface;
use Psr\Log\LoggerAwareTrait;
use TYPO3\CMS\Core\Cache\Frontend\FrontendInterface;
+use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
use TYPO3\CMS\Core\Utility\GeneralUtility;
// Fallback to the PHAR archive containing the dependency on the vimeo API in case
--
GitLab