From 17a8fb89405c4270a49f4181fc8829ba7a015db9 Mon Sep 17 00:00:00 2001
From: Stefan Galinski <stefan@sgalinski.de>
Date: Wed, 10 Aug 2022 13:23:40 +0200
Subject: [PATCH] [BUGFIX] Cleanup and PHP 8 errors
---
Classes/Controller/NewsFeedController.php | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/Classes/Controller/NewsFeedController.php b/Classes/Controller/NewsFeedController.php
index c986f50..696cf91 100644
--- a/Classes/Controller/NewsFeedController.php
+++ b/Classes/Controller/NewsFeedController.php
@@ -38,7 +38,14 @@ class NewsFeedController extends AbstractController {
/**
* @var NewsRepository
*/
- protected $newsRepository;
+ protected NewsRepository $newsRepository;
+
+ /**
+ * @param NewsRepository $newsRepository
+ */
+ public function injectNewsRepository(NewsRepository $newsRepository) {
+ $this->newsRepository = $newsRepository;
+ }
/**
* Renders the news feed
@@ -49,8 +56,8 @@ class NewsFeedController extends AbstractController {
public function indexAction(): ?\Psr\Http\Message\ResponseInterface {
$categories = GeneralUtility::intExplode(',', $this->settings['showCategories'], TRUE);
$tags = GeneralUtility::intExplode(',', $this->settings['showTags'], TRUE);
- $startTime = (int) $this->settings['starttime'];
- $endTime = (int) $this->settings['endtime'];
+ $startTime = (int) ($this->settings['starttime'] ?? 0);
+ $endTime = (int) ($this->settings['endtime'] ?? 0);
$news = $this->newsRepository->findLastUpdatedOrHighlightedNewsByCategories(
10,
FALSE,
@@ -85,15 +92,8 @@ class NewsFeedController extends AbstractController {
if (version_compare(\TYPO3\CMS\Core\Utility\VersionNumberUtility::getCurrentTypo3Version(), '11.0.0', '<')) {
return NULL;
- } else {
- return $this->htmlResponse();
}
- }
- /**
- * @param NewsRepository $newsRepository
- */
- public function injectNewsRepository(NewsRepository $newsRepository) {
- $this->newsRepository = $newsRepository;
+ return $this->htmlResponse();
}
}
--
GitLab