diff --git a/Classes/Command/SendMailCommandController.php b/Classes/Command/SendMailCommandController.php index 5c21e2fa0765ee7a9168d842e892850431a67762..7b382da41a5b886cca39953e51982c0ec5cf2485 100644 --- a/Classes/Command/SendMailCommandController.php +++ b/Classes/Command/SendMailCommandController.php @@ -85,27 +85,28 @@ class SendMailCommandController extends CommandController { $mailMessage->setFrom($fromAddress, $mailToSend->getFromName()); $mailMessage->setTo($toAddresses); $mailMessage->setSubject($mailSubject); - if (count($ccAddresses)) { + if (\count($ccAddresses)) { $mailMessage->setCc($ccAddresses); } - if (count($bccAddresses)) { + + if (\count($bccAddresses)) { $mailMessage->setBcc($bccAddresses); } $mailMessage->setBody($mailBody, 'text/html'); - $plaintextService = GeneralUtility::makeInstance(PlaintextService::class); - $plaintextBody = $plaintextService->makePlain($mailBody); - $mailMessage->addPart($plaintextBody, 'text/plain'); + $plaintextService = GeneralUtility::makeInstance(PlaintextService::class); + $plaintextBody = $plaintextService->makePlain($mailBody); + $mailMessage->addPart($plaintextBody, 'text/plain'); - $attachments = $mailToSend->getAttachments(); - if ($attachments->count() > 0) { - foreach ($attachments as $attachment) { + $attachments = $mailToSend->getAttachments(); + if ($attachments->count() > 0) { + foreach ($attachments as $attachment) { /** * @var FileReference $attachment */ $file = $attachment->getOriginalResource()->getOriginalFile(); - $mailMessage->attach( - \Swift_Attachment::newInstance($file->getContents(), $file->getName(), $file->getMimeType()) + $mailMessage->attach( + \Swift_Attachment::newInstance($file->getContents(), $file->getName(), $file->getMimeType()) ); } } diff --git a/Classes/Controller/MailController.php b/Classes/Controller/MailController.php index 053b2f0d276d6aa84629194fd0bfc1836739474e..62c6ca7891119613dfafc78138ec9b34824e8dca 100644 --- a/Classes/Controller/MailController.php +++ b/Classes/Controller/MailController.php @@ -157,7 +157,6 @@ class MailController extends ActionController { foreach ($templatesFromDb as $key => $template) { if ($template === NULL) { $defaultTemplatePath = $registerArray[$parameters['selectedExtension']][$parameters['selectedTemplate']]['templatePath']; - $defaultTemplateFile = $defaultTemplatePath . $key . '.' . 'template.html'; $fallbackTemplateFile = $defaultTemplatePath . 'template.html'; $templateFromFile = new Template(); @@ -177,10 +176,8 @@ class MailController extends ActionController { $subject = $registerArray[$parameters['selectedExtension']][$parameters['selectedTemplate']]['subject']; if ($registerArray[$parameters['selectedExtension']][$parameters['selectedTemplate']]['templateContent']) { $templateFromFile->setContent($registerArray[$parameters['selectedExtension']][$parameters['selectedTemplate']]['templateContent']); - } else { - if (file_exists($fallbackTemplateFile)) { - $templateFromFile->setContent(file_get_contents($fallbackTemplateFile)); - } + } elseif (file_exists($fallbackTemplateFile)) { + $templateFromFile->setContent(file_get_contents($fallbackTemplateFile)); } } else { $templates[$key] = $template; diff --git a/Classes/Controller/QueueController.php b/Classes/Controller/QueueController.php index 34a6a462b22502155c1413b5c92004d8dd3cbb40..8cdd1ce98a7c0d28e74fc30f0509167b1e9dadb1 100644 --- a/Classes/Controller/QueueController.php +++ b/Classes/Controller/QueueController.php @@ -186,8 +186,6 @@ class QueueController extends ActionController { * Download the queue data as a csv file, respecting the filter settings * * @param array $filters - * @throws \TYPO3\CMS\Extbase\Mvc\Exception\StopActionException - * @throws \TYPO3\CMS\Extbase\Mvc\Exception\UnsupportedRequestTypeException * @throws \TYPO3\CMS\Extbase\Persistence\Exception\InvalidQueryException * @throws \InvalidArgumentException */ @@ -197,7 +195,7 @@ class QueueController extends ActionController { header('Content-Type: application/force-download'); header('Content-Transfer-Encoding: Binary'); header('Content-Disposition: attachment; filename="export.csv"'); - header('Content-Length: ' . strlen($exportString)); + header('Content-Length: ' . \strlen($exportString)); echo $exportString; exit(0); } diff --git a/Classes/Domain/Repository/AbstractRepository.php b/Classes/Domain/Repository/AbstractRepository.php index 162c7b8083fe24020cabd1b230be2119dcede7a0..fd76ce5911a308b515c9ef284a5d54c2670ad216 100644 --- a/Classes/Domain/Repository/AbstractRepository.php +++ b/Classes/Domain/Repository/AbstractRepository.php @@ -58,7 +58,7 @@ abstract class AbstractRepository extends Repository { * @param bool $ignoreEnableFields * @return string */ - protected function getEnableFieldsStatement($table, $alias = '', $ignoreEnableFields = FALSE) { + protected function getEnableFieldsStatement($table, $alias = '', $ignoreEnableFields = FALSE): string { if (TYPO3_MODE === 'FE' && $GLOBALS['TSFE'] instanceof TypoScriptFrontendController) { /** @var PageRepository $pageRepository */ $pageRepository = $GLOBALS['TSFE']->sys_page; diff --git a/Classes/Domain/Repository/MailRepository.php b/Classes/Domain/Repository/MailRepository.php index 42e966bc2b59970ffda077505b271fb074786abc..fd47e98da8a2fb04574a28a6af095e31e305dbc5 100644 --- a/Classes/Domain/Repository/MailRepository.php +++ b/Classes/Domain/Repository/MailRepository.php @@ -90,12 +90,10 @@ class MailRepository extends AbstractRepository { foreach (BackendService::getLanguages() as $lang) { $constraintsAnd[] = $query->logicalNot($query->equals('language', $lang['isocode'])); } - } else { - if ($filters['filterLanguage'] && $filters['filterLanguage'] !== 0 - && $filters['filterLanguage'] !== '0' && $filters['filterLanguage'] !== '' - ) { - $constraintsAnd[] = $query->equals('language', $filters['filterLanguage']); - } + } elseif ($filters['filterLanguage'] && $filters['filterLanguage'] !== 0 + && $filters['filterLanguage'] !== '0' && $filters['filterLanguage'] !== '' + ) { + $constraintsAnd[] = $query->equals('language', $filters['filterLanguage']); } $constraintsOr = []; diff --git a/Classes/Domain/Repository/TemplateRepository.php b/Classes/Domain/Repository/TemplateRepository.php index b72e3bc21e2362adcb2243f59209c8a1d3624b55..fdc3347cb4be2842b867a705d4a1a00a71756dc8 100644 --- a/Classes/Domain/Repository/TemplateRepository.php +++ b/Classes/Domain/Repository/TemplateRepository.php @@ -26,7 +26,6 @@ namespace SGalinski\SgMail\Domain\Repository; * This copyright notice MUST APPEAR in all copies of the script! ***************************************************************/ -use SGalinski\SgMail\Domain\Model\Template; use TYPO3\CMS\Core\Database\DatabaseConnection; use TYPO3\CMS\Extbase\Persistence\Generic\Typo3QuerySettings; diff --git a/ext_localconf.php b/ext_localconf.php index 703efd9044b69064a9b0b47f21db3869a1b0eea6..18cd1ee1c5cece597e0b9c885ceabe0d32a79cf1 100644 --- a/ext_localconf.php +++ b/ext_localconf.php @@ -67,4 +67,3 @@ if (!isset($TYPO3_CONF_VARS['SYS']['caching']['cacheConfigurations'][$cacheName] 'citypower' ]; } -