From 967192b1374a9662c9b6d8f4c02d5213e40c7b4f Mon Sep 17 00:00:00 2001
From: Kevin Ditscheid <kevin.ditscheid@sgalinski.de>
Date: Wed, 16 May 2018 19:26:48 +0200
Subject: [PATCH] [BUGFIX] Do not add all the arguments to the redirect on
template save
The only arguments to be sent should be the required ones:
selectedExtension and selectedTemplate to prevent the redirect url
from becoming to long for some web servers to handle
---
Classes/Controller/MailController.php | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/Classes/Controller/MailController.php b/Classes/Controller/MailController.php
index 2e21e11d..875b3f8f 100644
--- a/Classes/Controller/MailController.php
+++ b/Classes/Controller/MailController.php
@@ -257,6 +257,13 @@ class MailController extends ActionController {
* @throws \TYPO3\CMS\Core\Cache\Exception\NoSuchCacheException
*/
public function sendTestMailAction(array $parameters = []) {
+ $arguments = [];
+ if ($parameters['selectedExtension']) {
+ $arguments['selectedExtension'] = $parameters['selectedExtension'];
+ }
+ if ($parameters['selectedTemplate']) {
+ $arguments['selectedTemplate'] = $parameters['selectedTemplate'];
+ }
foreach ((array) $parameters['templates'] as $parameter) {
$ccAddresses = GeneralUtility::trimExplode(',', $parameter['cc']);
if (\count($ccAddresses) > 0) {
@@ -266,7 +273,6 @@ class MailController extends ActionController {
$message = LocalizationUtility::translate('backend.error_cc', 'sg_mail');
$this->addFlashMessage($message, '', FlashMessage::WARNING);
- $arguments = $this->request->getArguments();
$this->redirect('index', NULL, NULL, $arguments);
}
}
@@ -279,7 +285,6 @@ class MailController extends ActionController {
$message = LocalizationUtility::translate('backend.error_bcc', 'sg_mail');
$this->addFlashMessage($message, '', FlashMessage::WARNING);
- $arguments = $this->request->getArguments();
$this->redirect('index', NULL, NULL, $arguments);
}
}
@@ -298,7 +303,6 @@ class MailController extends ActionController {
if (!$this->request->hasArgument('saveOnly')) {
if (!filter_var($parameters['emailAddress'], FILTER_VALIDATE_EMAIL)) {
- $arguments = $this->request->getArguments();
$this->redirect('index', NULL, NULL, $arguments);
}
@@ -326,7 +330,6 @@ class MailController extends ActionController {
$this->addFlashMessage($message, '', FlashMessage::ERROR);
}
}
- $arguments = $this->request->getArguments();
$this->redirect('index', NULL, NULL, $arguments);
}
--
GitLab