From 111324982897f658141e320f2e6de72802fa59a6 Mon Sep 17 00:00:00 2001
From: Torsten Oppermann <torsten@sgalinski.de>
Date: Fri, 4 Aug 2017 16:58:26 +0200
Subject: [PATCH] [TASK] Style reviews
---
Resources/Private/Language/de.locallang.xlf | 12 +++++-
Resources/Private/Language/locallang.xlf | 8 +++-
Resources/Private/Partials/Queue/Filter.html | 41 ++++++++++++--------
Resources/Private/Templates/Queue/Index.html | 29 +++++++++++---
Resources/Public/StyleSheets/backend.css | 5 +++
5 files changed, 70 insertions(+), 25 deletions(-)
diff --git a/Resources/Private/Language/de.locallang.xlf b/Resources/Private/Language/de.locallang.xlf
index 92ec1cd2..350a2642 100644
--- a/Resources/Private/Language/de.locallang.xlf
+++ b/Resources/Private/Language/de.locallang.xlf
@@ -25,6 +25,10 @@
<source>Reset template</source>
<target>Template zurücksetzen</target>
</trans-unit>
+ <trans-unit id="backend.button_reset_filter" approved="yes">
+ <source>Reset</source>
+ <target>Zurücksetzen</target>
+ </trans-unit>
<trans-unit id="backend.cc" approved="yes">
<source>CC (Carbon Copy Receiver, comma separated)</source>
<target>CC (Kopieempfänger, komma-separiert)</target>
@@ -77,6 +81,10 @@
<source>Last sent until:</source>
<target>Zuletzt gesendet bis:</target>
</trans-unit>
+ <trans-unit id="backend.filter.extension" approved="yes">
+ <source>Extension</source>
+ <target>Extension</target>
+ </trans-unit>
<trans-unit id="backend.filter.fields.description" approved="yes">
<source>Search fields (all by default):</source>
<target>Suchfelder (standardmäßig alle):</target>
@@ -114,8 +122,8 @@
<target>Betreff</target>
</trans-unit>
<trans-unit id="backend.filter.template" approved="yes">
- <source>Template:</source>
- <target>Template:</target>
+ <source>Template</source>
+ <target>Template</target>
</trans-unit>
<trans-unit id="backend.filter.to" approved="yes">
<source>Recipient address</source>
diff --git a/Resources/Private/Language/locallang.xlf b/Resources/Private/Language/locallang.xlf
index 6166d70d..b83b2906 100644
--- a/Resources/Private/Language/locallang.xlf
+++ b/Resources/Private/Language/locallang.xlf
@@ -21,6 +21,9 @@
<trans-unit id="backend.button_reset_all">
<source>Reset template</source>
</trans-unit>
+ <trans-unit id="backend.button_reset_filter">
+ <source>Reset</source>
+ </trans-unit>
<trans-unit id="backend.cc">
<source>CC (Carbon Copy Receiver, comma separated)</source>
</trans-unit>
@@ -60,6 +63,9 @@
<trans-unit id="backend.filter.date_to">
<source>Last sent until:</source>
</trans-unit>
+ <trans-unit id="backend.filter.extension">
+ <source>Extension</source>
+ </trans-unit>
<trans-unit id="backend.filter.fields.description">
<source>Search fields (all by default):</source>
</trans-unit>
@@ -88,7 +94,7 @@
<source>Subject</source>
</trans-unit>
<trans-unit id="backend.filter.template">
- <source>Template:</source>
+ <source>Template</source>
</trans-unit>
<trans-unit id="backend.filter.to">
<source>Recipient address</source>
diff --git a/Resources/Private/Partials/Queue/Filter.html b/Resources/Private/Partials/Queue/Filter.html
index beb2447d..b4a51e5b 100644
--- a/Resources/Private/Partials/Queue/Filter.html
+++ b/Resources/Private/Partials/Queue/Filter.html
@@ -18,19 +18,19 @@
<f:then>
<sgm:be.menus.actionMenuOptionGroup label="{extensionKey}">
<f:for each="{extension}" as="template">
- <sgm:extendedIf condition="{selectedTemplateFilter} == {template}"
- and="{selectedExtensionFilter} == {extensionKey}">
- <f:then>
- <option value="{extensionKey}###{template}" selected="selected">
- {template}
- </option>
- </f:then>
- <f:else>
- <option value="{extensionKey}###{template}">
- {template}
- </option>
- </f:else>
- </sgm:extendedIf>
+ <sgm:extendedIf condition="{selectedTemplateFilter} == {template}"
+ and="{selectedExtensionFilter} == {extensionKey}">
+ <f:then>
+ <option value="{extensionKey}###{template}" selected="selected">
+ {template}
+ </option>
+ </f:then>
+ <f:else>
+ <option value="{extensionKey}###{template}">
+ {template}
+ </option>
+ </f:else>
+ </sgm:extendedIf>
</f:for>
</sgm:be.menus.actionMenuOptionGroup>
</f:then>
@@ -112,9 +112,18 @@
<f:translate key="backend.not_sent" />
</label>
</div>
- <div class="form-group">
- <f:form.button class="btn btn-success form-group col-xs-12 col-md-12" type="submit">
- <f:translate key="backend.filter.filter" /></f:form.button>
+ <div class="form-group row">
+ <div class="col-md-6">
+ <f:form.button class="btn btn-success form-group col-xs-12 col-md-12" type="submit">
+ <f:translate key="backend.filter.filter" />
+ </f:form.button>
+ </div>
+
+ <div class="col-md-6">
+ <f:form.button class="btn btn-danger form-group col-xs-12 col-md-12" type="reset">
+ <f:translate key="backend.button_reset_filter" />
+ </f:form.button>
+ </div>
</div>
</div>
</div>
diff --git a/Resources/Private/Templates/Queue/Index.html b/Resources/Private/Templates/Queue/Index.html
index a986a7d0..dfd862e3 100644
--- a/Resources/Private/Templates/Queue/Index.html
+++ b/Resources/Private/Templates/Queue/Index.html
@@ -18,7 +18,9 @@
<tr>
<th></th>
<th><f:translate key="backend.from" /> <br> <f:translate key="backend.to" /></th>
- <th><f:translate key="backend.subject" /></th>
+ <th><f:translate key="backend.filter.extension" />:
+ <f:translate key="backend.filter.template" /> <br>
+ <f:translate key="backend.subject" /></th>
<th><f:translate key="backend.entry_date" /> <br>
<f:translate key="backend.last_sent" /></th>
<th></th>
@@ -33,7 +35,7 @@
<tr data-uid="{mail.uid}">
</f:then>
<f:else>
- <tr data-uid="{mail.uid}" style="background-color: #C8C8C8;">
+ <tr data-uid="{mail.uid}" style="background-color: #7C7C7C;">
</f:else>
</f:if>
<td nowrap="nowrap" class="col-icon">
@@ -43,17 +45,32 @@
</td>
<td>
<span>{mail.from_address}</span>
- <br>
+ <hr>
<span>{mail.to_address}</span>
</td>
<td>
- <span><f:format.crop maxCharacters="40" append="...">{mail.mail_subject}</f:format.crop></span>
+ <span>{mail.extension_key}: {mail.template_name}</span>
+ <hr>
+ <f:if condition="{mail.mail_subject}">
+ <f:then>
+ <span><f:format.crop maxCharacters="40" append="...">{mail.mail_subject}</f:format.crop></span>
+ </f:then>
+ <f:else>
+
+ </f:else>
+ </f:if>
+
</td>
<td>
<span><f:format.date format="d.m.Y h:i">{mail.crdate}</f:format.date></span>
- <br>
+ <hr>
<f:if condition="{mail.last_sending_time} != 0">
- <span><f:format.date format="d.m.Y h:i">{mail.last_sending_time}</f:format.date></span>
+ <f:then>
+ <span><f:format.date format="d.m.Y h:i">{mail.last_sending_time}</f:format.date></span>
+ </f:then>
+ <f:else>
+ <f:translate key="backend.not_sent" />
+ </f:else>
</f:if>
</td>
<td nowrap="nowrap" class="col-control">
diff --git a/Resources/Public/StyleSheets/backend.css b/Resources/Public/StyleSheets/backend.css
index 3d0349f4..5d6c5dfa 100644
--- a/Resources/Public/StyleSheets/backend.css
+++ b/Resources/Public/StyleSheets/backend.css
@@ -64,4 +64,9 @@
.template-col:nth-of-type(odd) {
/*background-color: #AAA;*/
/*background-clip: content-box;*/
+}
+
+hr {
+ margin: 5px 0;
+ border-top: 1px solid #CCC;
}
\ No newline at end of file
--
GitLab