diff --git a/Classes/Controller/JoblistController.php b/Classes/Controller/JoblistController.php index 5666b370694b88f3dce22ca752f95852beb7f0ea..4b1bd2b3eca8e7ebb843e6d73f3040eedf48c744 100644 --- a/Classes/Controller/JoblistController.php +++ b/Classes/Controller/JoblistController.php @@ -26,6 +26,7 @@ namespace SGalinski\SgJobs\Controller; * This copyright notice MUST APPEAR in all copies of the script! ***************************************************************/ +use Psr\Http\Message\ResponseInterface; use SGalinski\ProjectBase\Domain\Repository\CountryRepository; use SGalinski\SgJobs\Domain\Model\Job; use SGalinski\SgJobs\Domain\Model\JobApplication; @@ -686,7 +687,7 @@ class JoblistController extends ActionController { /** * If for any reason something goes wrong, delete the tmp upload folder * - * @return void + * @return mixed * @throws NoSuchArgumentException */ public function errorAction() { @@ -695,7 +696,7 @@ class JoblistController extends ActionController { $this->deleteTmpFolder($folderName); } - parent::errorAction(); + return parent::errorAction(); } /** diff --git a/Classes/Domain/Model/Job.php b/Classes/Domain/Model/Job.php index 994c39333234754f664c3518bea5e6e39a06aa21..a5ba2aaa66ae73bf72f02072a515588d46d91ef8 100644 --- a/Classes/Domain/Model/Job.php +++ b/Classes/Domain/Model/Job.php @@ -108,7 +108,7 @@ class Job extends AbstractEntity { /** * @var \SGalinski\SgJobs\Domain\Model\Company $company */ - protected $company = ''; + protected $company; /** * @var string $description diff --git a/Classes/Hooks/PageLayoutView/PluginRenderer.php b/Classes/Hooks/PageLayoutView/PluginRenderer.php index ac9cae73cb80cad3481d5585aa6fffc4805f7d5b..226dc649dbab2f8edd1ee086febbfd92b571d6d9 100644 --- a/Classes/Hooks/PageLayoutView/PluginRenderer.php +++ b/Classes/Hooks/PageLayoutView/PluginRenderer.php @@ -87,8 +87,8 @@ class PluginRenderer implements \TYPO3\CMS\Backend\View\PageLayoutViewDrawItemHo * Adapts the given $headerContent. * To be used in all plugin previews so the Header Contents appear similarly. * - * @param $headerContent - * @param $row + * @param string $headerContent + * @param array $row */ protected function adaptPluginHeaderContent(&$headerContent, $row): void { $headerContent = '<h4>' . $this->getPluginNameForHeaderContent( diff --git a/Classes/Paginator/QueryResultRawPaginator.php b/Classes/Paginator/QueryResultRawPaginator.php index 5452162c76932a58a94ea3269f5c4a2fa80fdb99..b255a54a6be37a1ce235ebf73e71a100ab0e5e34 100644 --- a/Classes/Paginator/QueryResultRawPaginator.php +++ b/Classes/Paginator/QueryResultRawPaginator.php @@ -31,7 +31,7 @@ final class QueryResultRawPaginator extends AbstractPaginator { private $queryResult; /** - * @var QueryResultInterface + * @var \TYPO3\CMS\Extbase\Persistence\QueryResultInterface|object[] */ private $paginatedQueryResult; diff --git a/Classes/Service/BackendService.php b/Classes/Service/BackendService.php index 073debe0c3109eb8fce7298f678883d91639d287..c107a90e5aaa122ec77932caa4dc24babb422258 100644 --- a/Classes/Service/BackendService.php +++ b/Classes/Service/BackendService.php @@ -55,7 +55,7 @@ class BackendService { ->from('pages') ->where( $queryBuilder->expr()->eq('is_siteroot', $queryBuilder->createNamedParameter(1, \PDO::PARAM_INT)) - )->execute()->fetchAll(); + )->execute()->fetchAllAssociative(); foreach ($rows as $row) { $pageInfo = BackendUtility::readPageAccess($row['uid'], $GLOBALS['BE_USER']->getPagePermsClause(1)); @@ -129,7 +129,7 @@ class BackendService { $rows = $queryBuilder->select('pid') ->from('tx_sgjobs_domain_model_job') ->groupBy('pid') - ->execute()->fetchAll(); + ->execute()->fetchAllAssociative(); foreach ($rows as $row) { $pageInfo = BackendUtility::readPageAccess($row['pid'], $GLOBALS['BE_USER']->getPagePermsClause(1)); if ($pageInfo) { diff --git a/Classes/Service/SitemapService.php b/Classes/Service/SitemapService.php index ed0d6a8f26d5d7cb7da373c04b0087b66d72a687..b79752064066976c6b2a4b70a70bbcc80f3e8e90 100644 --- a/Classes/Service/SitemapService.php +++ b/Classes/Service/SitemapService.php @@ -60,7 +60,7 @@ class SitemapService { ->execute(); $context = GeneralUtility::makeInstance(Context::class); - while ($row = $databaseResource->fetch()) { + while ($row = $databaseResource->fetchAssociative()) { try { $site = GeneralUtility::makeInstance(SiteFinder::class)->getSiteByPageId($row['pid']); if ($rootPageId > 0 && $site->getRootPageId() !== $rootPageId) {