sg_cookie_optin issueshttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues2022-10-17T12:06:28Zhttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/247Make the footer links paths relative2022-10-17T12:06:28ZGeorgiMake the footer links paths relative5.0.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/246Evaluate if it's possible to use tracman.js for sg cookie optin2022-11-28T21:05:55ZGeorgiEvaluate if it's possible to use tracman.js for sg cookie optin5.0.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/245Move the hardcoded mustache CSS values to CSS variables and introduce dark th...2022-10-27T20:59:01ZGeorgiMove the hardcoded mustache CSS values to CSS variables and introduce dark theme support5.0.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/244Drop IE support2022-11-28T21:05:37ZGeorgiDrop IE support5.0.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/242Drop official support for TYPO3 82022-11-28T21:05:26ZGeorgiDrop official support for TYPO3 85.0.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/241Filter for values saved into tx_sgcookieoptin_domain_model_user_preference (i...2022-10-03T21:10:19ZManuel MunzFilter for values saved into tx_sgcookieoptin_domain_model_user_preference (item_identifier column)So it seems someone tried to do SQL injections at one instance where we use the plugin (current 4.6.0 version) via the tx_sgcookieoptin_domain_model_user_preference table.
```
SELECT DISTINCT item_identifier FROM tx_sgcookieoptin_domain...So it seems someone tried to do SQL injections at one instance where we use the plugin (current 4.6.0 version) via the tx_sgcookieoptin_domain_model_user_preference table.
```
SELECT DISTINCT item_identifier FROM tx_sgcookieoptin_domain_model_user_preference;
essential
marketing
statistiken
-1 OR OR 2+205-205-1=0+0+0+1
-1 OR 2+210-210-1=0+0+0+1 --
[hundreds more]
```
In the backend module for statistics then a pie chart is created for every value of item_identifier:
![image](/uploads/5e6f28e18b6d9267fd40ee8ee4e28753/image.jpg)
Note: The first graph is probably for item_identifier = '', not sure if this should ever happen.
A possible solution could be to filter for valid 'Service groups' before inserting them in OptinHistoryService.php5.0.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/238Feature request: allow HTML content in data-consent-description2022-09-27T12:34:01ZManfred EggerFeature request: allow HTML content in data-consent-descriptionWhen adding a description to protected external content only plaintext inside data-consent-description attribute is possible at the moment. The data protection officer of one of our customers want's to have a link to the privacy protecti...When adding a description to protected external content only plaintext inside data-consent-description attribute is possible at the moment. The data protection officer of one of our customers want's to have a link to the privacy protection information of an external tool inside this description. Would it be possible to add this feature?5.0.0https://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/237overwrite_baseurl produces invalid js url2022-12-13T11:47:47ZHenrikoverwrite_baseurl produces invalid js urlsetting a value for overwrite_baseurl (for example https://mydomain.de) produces an invalid URL for the JavaScript-Include, CSS is working as expected.
generated CSS-Code (`Classes/UserFunction/AddCookieOptinJsAndCss.php` at line 110)
`...setting a value for overwrite_baseurl (for example https://mydomain.de) produces an invalid URL for the JavaScript-Include, CSS is working as expected.
generated CSS-Code (`Classes/UserFunction/AddCookieOptinJsAndCss.php` at line 110)
```html
<link rel="preload" as="style" href="https://mydomain.de/fileadmin/sg_cookie_optin/siteroot-1/cookieOptin.css?1663159745" media="all" crossorigin="anonymous">
<link rel="stylesheet" href="https://mydomain.de/fileadmin/sg_cookie_optin/siteroot-1/cookieOptin.css?1663159745" media="all" crossorigin="anonymous">
```
generated JS-Code (`Classes/UserFunction/AddCookieOptinJsAndCss.php` at line 162)
```html
<link rel="preload" as="script" href="https://mydomain.de/" data-ignore="1" crossorigin="anonymous">
<script src="https://mydomain.de/" data-ignore="1" crossorigin="anonymous"></script>
```5.0.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/236Fix PHP 7.0 issues2022-09-09T12:29:40ZGeorgiFix PHP 7.0 issuesThere are still some public const in TemplateService left and possibly in other placesThere are still some public const in TemplateService left and possibly in other places5.0.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/230Add data-nosnippet to Cookiebanner div2022-09-08T10:29:37ZOliver KrammerAdd data-nosnippet to Cookiebanner divPrevent that the Cookiebanner text will shown at Google search results
https://developers.google.com/search/docs/advanced/robots/robots_meta_tag?hl=de#data-nosnippet-attrPrevent that the Cookiebanner text will shown at Google search results
https://developers.google.com/search/docs/advanced/robots/robots_meta_tag?hl=de#data-nosnippet-attr5.0.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/226Google Lighthouse test says "tabindex" in templates is an accessibility issue2022-10-03T21:15:10ZTobi WollenderGoogle Lighthouse test says "tabindex" in templates is an accessibility issueWhen testing a website with sg_cookie_optin through https://web.dev we get the following errors for the cookie-banner (in the accessibility section):
`Some elements have a [tabindex] value greater than 0`
According https://web.dev/tabi...When testing a website with sg_cookie_optin through https://web.dev we get the following errors for the cookie-banner (in the accessibility section):
`Some elements have a [tabindex] value greater than 0`
According https://web.dev/tabindex/ it says
`Although technically valid, using a tabindex greater than 0 is considered an anti-pattern because it shifts the affected element to the end of the tab order. This unexpected behavior can make it seem like some elements can't be accessed via keyboard, which is frustrating for users who rely on assistive technologies.`
So maybe you can optimize this5.0.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/205Fingerprint icon like User centrics to open the popup2022-09-12T10:49:07ZStefan Galinskistefan@sgalinski.deFingerprint icon like User centrics to open the popup![image](/uploads/d728b2a57992a172485d781084d93927/image.png)
- Possible to define the place (bottom/top left/right).
- Opens the consent
- Only visible if not opened
- Color and tooltip definable![image](/uploads/d728b2a57992a172485d781084d93927/image.png)
- Possible to define the place (bottom/top left/right).
- Opens the consent
- Only visible if not opened
- Color and tooltip definable5.0.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/204New file name for CSS/JS2022-12-12T05:07:42ZStefan Galinskistefan@sgalinski.deNew file name for CSS/JS![image](/uploads/f6a0bb66e75544e39a086f42c97346c3/image.png)
Include a hash inside the filename to allow proper preloading and caching. The query cache buster can be removed then.![image](/uploads/f6a0bb66e75544e39a086f42c97346c3/image.png)
Include a hash inside the filename to allow proper preloading and caching. The query cache buster can be removed then.5.0.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/190External Content - Special implementation YouTube/Vimeo2022-10-21T08:57:56ZStefan Galinskistefan@sgalinski.deExternal Content - Special implementation YouTube/VimeoAnd for Youtube it would be good to have an integrated function that saves the thumbnails locally and you can then use them in the content window. Like Nicole does with her extension social_gdpr (https://github.com/IchHabRecht/social_gdpr).And for Youtube it would be good to have an integrated function that saves the thumbnails locally and you can then use them in the content window. Like Nicole does with her extension social_gdpr (https://github.com/IchHabRecht/social_gdpr).5.0.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/189Enhance Look & Feel of the External Content Layer2022-10-03T21:16:32ZStefan Galinskistefan@sgalinski.deEnhance Look & Feel of the External Content LayerIt would be cool if you could not only give the consent for the external content depending on the service, but then also customize the templates individually. So that you can make e.g. uncomplicated for Youtube another Consent window tha...It would be cool if you could not only give the consent for the external content depending on the service, but then also customize the templates individually. So that you can make e.g. uncomplicated for Youtube another Consent window than for Google Maps (with special icons/background graphics/texts etc.).5.0.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/180Extend the functionality for loading of external content by custom domains2022-10-03T21:16:14ZStefan Galinskistefan@sgalinski.deExtend the functionality for loading of external content by custom domainsExterner Inhalt von:
https://www.facebook.com/
- Diesen externen Inhalt laden
- Alle externen Inhalte von dieser Domain laden
- Alle externen Inhalte von allen Domains laden
Externer Inhalt von:
https://www.youtube-nocookie.com/
- Diese...Externer Inhalt von:
https://www.facebook.com/
- Diesen externen Inhalt laden
- Alle externen Inhalte von dieser Domain laden
- Alle externen Inhalte von allen Domains laden
Externer Inhalt von:
https://www.youtube-nocookie.com/
- Diesen externen Inhalt laden
- Alle externen Inhalte von dieser Domain laden
- Alle externen Inhalte von allen Domains laden5.0.0https://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/164Remove the deprecated v2 embedding of the JSON data2022-10-03T21:10:34ZGeorgiRemove the deprecated v2 embedding of the JSON dataIn AddCookieOptinJsAndCss.php there is a fragment starting with
`// Old including from version 2.X.X @todo remove in version 4.X.X`
remove itIn AddCookieOptinJsAndCss.php there is a fragment starting with
`// Old including from version 2.X.X @todo remove in version 4.X.X`
remove it5.0.0https://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/158List of Cookies as Content Element2022-10-17T12:05:09ZOliver KrammerList of Cookies as Content ElementIt would be nice if we have a Content Element where we get all Cookies.
As Example look at https://azubi-eignungstest.de/datenschutzerklaerung/ -> 6. Cookies
OliverIt would be nice if we have a Content Element where we get all Cookies.
As Example look at https://azubi-eignungstest.de/datenschutzerklaerung/ -> 6. Cookies
Oliver5.0.0GeorgiGeorgi