sg_cookie_optin issueshttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues2023-08-09T13:27:34Zhttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/278Customizable Fluid template paths for cookielist plugin2023-08-09T13:27:34ZSebastian KleinCustomizable Fluid template paths for cookielist pluginIt would be useful to override the template paths for the "Cookie List" plugin.
Currently, no override via TypoScript is possible. The paths are fixed inside the OptinController:
if ($optin['template_selection'] === 1) {
$t...It would be useful to override the template paths for the "Cookie List" plugin.
Currently, no override via TypoScript is possible. The paths are fixed inside the OptinController:
if ($optin['template_selection'] === 1) {
$templateNameAndPath = 'EXT:sg_cookie_optin/Resources/Private/Templates/CookieList/Full.html';
} else {
$templateNameAndPath = 'EXT:sg_cookie_optin/Resources/Private/Templates/CookieList/Default.html';
}
$view->setTemplatePathAndFilename(GeneralUtility::getFileAbsFileName($templateNameAndPath));
$view->setPartialRootPaths(['EXT:sg_cookie_optin/Resources/Private/Partials']);
$view->setLayoutRootPaths(['EXT:sg_cookie_optin/Resources/Private/Layouts']);
I can see the following advantages:
1. **Custom markup for the table/plugin.** For example: The plugin itself has a mandatory headline and description, which might be undesired to render (if the plugin is placed on a data privacy page with already existing explanation text).
2. **Rendering HTML markup in cookie group description.** I know, the description field provides no RTE. But we recently used HTML links in it, and these links were correctly rendered **inside the consent modal**. Only the "Cookie list" Fluid template renders it as plain text (which would have been an easy fix in the project using `{group.description -> f:format.html()}`).
What do you think?5.3.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/276Options to auto-accept bots to "ACCEPT" or "REJECT" (Default "ACCEPT")2023-08-03T12:22:45ZStefan Galinskistefan@sgalinski.deOptions to auto-accept bots to "ACCEPT" or "REJECT" (Default "ACCEPT")![33E5C119-A071-47C7-9497-5CB021A041FB](/uploads/ea121385f8f075a61b006e5ce5494c10/33E5C119-A071-47C7-9497-5CB021A041FB.png)
We are again concerned with the issue of consent for bots: as we had also discussed, it makes sense to treat bot...![33E5C119-A071-47C7-9497-5CB021A041FB](/uploads/ea121385f8f075a61b006e5ce5494c10/33E5C119-A071-47C7-9497-5CB021A041FB.png)
We are again concerned with the issue of consent for bots: as we had also discussed, it makes sense to treat bots as users who have accepted all cookies, right? The Borlabs Cookie for Wordpress, for example, also has this option:
So, the cookie banner is not technically disabled but assumes existing consent. If the consent for bots does not exist, the GoogleBot, for example, will not notice that there are also videos in the page, which can be SEO-relevant.
Important: If set to ACCEPT, the consent should not be shown.6.0.0https://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/275Add option to combine the JSON configuration with the JS file (default "on")2023-08-03T12:20:37ZStefan Galinskistefan@sgalinski.deAdd option to combine the JSON configuration with the JS file (default "on")This would clean up the head area of the website.
---
- Instead of the JSON files, we should add this to localized javascript files and load them. Reduces the initial HTML file size in favor a cachable JS file. Also cleans up the HEAD ...This would clean up the head area of the website.
---
- Instead of the JSON files, we should add this to localized javascript files and load them. Reduces the initial HTML file size in favor a cachable JS file. Also cleans up the HEAD area a lot.6.0.0https://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/274Accessibility Issues (BITV)2023-05-24T13:53:07ZStefan Galinskistefan@sgalinski.deAccessibility Issues (BITV)Es fehlen verschiedene ARIA-Rollenzuordnungen und Attribute
* Die Checkboxen "Analytic-Cookies" und "Externe Inhalte" sind nicht als solche erkennbar.
* Die Funktion "Weitere Informationen anzeigen" muss als button angelegt werden (es h...Es fehlen verschiedene ARIA-Rollenzuordnungen und Attribute
* Die Checkboxen "Analytic-Cookies" und "Externe Inhalte" sind nicht als solche erkennbar.
* Die Funktion "Weitere Informationen anzeigen" muss als button angelegt werden (es handelt sich nicht um einen Hyperlink). Zudem muss der Status mit aria-expanded vermittelt werden.
* Die ausklappbaren Inhalte sind im Screenreader auch im eingeklappten Zustand lesbar.
* Der Dialog sollte mit den entsprechenden ARIA-Rollen ausgezeichnet werden.
----
Hier nochmal die Zusammenfassung aller Punkte:
1. Cookie-Consent: Die Inhalte des Cookie-Dialogs werden als modaler Dialog dargestellt. Die Inhalte des Dialogs erhalten jedoch erst den Fokus nachdem die Seiteninhalte im ausgegrauten Hintergrund angesteuert wurden.
----> Hier ist die Frage ob das eher bei euch oder bei uns liegt, gut wäre es wenn man den Tastaturfocus natürlich als erstes auf eurer Extension hat und im „Kreis“ tabt bis man das Tool schließt, dann erst unsere Tasturfolge greift.
2. Cookie-Consent: Innerhalb des Cookie-Dialogs enthalten Inhalte den Tastaturfokus, die in der visuellen Darstellung ausgeblendet sind. Dabei handelt es sich um die Inhalte unter "Weitere Informationen anzeigen".
3. Cookie-Consent: Es fehlen verschiedene ARIA-Rollenzuordnungen und Attribute * Die Checkboxen "Analytic-Cookies" und "Externe Inhalte" sind nicht als solche erkennbar. * Die Funktion "Weitere Informationen anzeigen" muss als button angelegt werden (es handelt sich nicht um einen Hyperlink). Zudem muss der Status mit aria-expanded vermittelt werden. * Die ausklappbaren Inhalte sind im Screenreader auch im eingeklappten Zustand lesbar. * Der Dialog sollte mit den entsprechenden ARIA-Rollen ausgezeichnet werden.
4. Cookie-Consent, betrifft die für Text und Buttons verwendete Farbkombination Weiß auf Grau #A5A5A5. Der Helligkeitskontrast liegt bei 2,5:1, der Grenzwert ist 4,5:1- Der Kontrastwer bei Fokushervorhebung mit der Maus ist noch deutlich schlechter.
-------> Hier ist klar, dass man die Farben anpassen kann, aber eventuell macht es Sinn, dass man auch den Focus direkt im Backend steuert oder aber standartmäßig den hover effekt auch als focus effekt nutzt (denke das ist am wenigsten Aufwand)5.2.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/269Cleanup Integration of table "tx_sgcookieoptin_domain_model_user_preference"2023-04-07T12:06:56ZStefan Galinskistefan@sgalinski.deCleanup Integration of table "tx_sgcookieoptin_domain_model_user_preference"This must be simply integrated into the standard TYPO3 cleanup command "Table Garbage Collection".
Default: 540 daysThis must be simply integrated into the standard TYPO3 cleanup command "Table Garbage Collection".
Default: 540 days5.2.0Stefan Galinskistefan@sgalinski.deStefan Galinskistefan@sgalinski.dehttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/257Add the monochrome SGalinski logo to the product information button2023-02-07T19:41:35ZGeorgiAdd the monochrome SGalinski logo to the product information button5.1.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/256Remove CookieServe iframe2023-02-07T19:41:40ZGeorgiRemove CookieServe iframeInstead add a button to the statistics and a button that leads to the CookieServe tool.Instead add a button to the statistics and a button that leads to the CookieServe tool.5.1.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/255Remove template selection fields where there is only one template available2023-02-07T19:41:59ZGeorgiRemove template selection fields where there is only one template availableOnly the Template field has more than one template and the rest of these field only cause confusion and complicationOnly the Template field has more than one template and the rest of these field only cause confusion and complication5.1.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/252Add an Essential button in the small cookie banner2023-02-09T13:34:31ZGeorgiAdd an Essential button in the small cookie banner5.1.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/251Add a checkbox "Show Fingerprint Icon"2023-02-09T13:34:31ZGeorgiAdd a checkbox "Show Fingerprint Icon"on by defaulton by default5.1.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/238Feature request: allow HTML content in data-consent-description2022-09-27T12:34:01ZManfred EggerFeature request: allow HTML content in data-consent-descriptionWhen adding a description to protected external content only plaintext inside data-consent-description attribute is possible at the moment. The data protection officer of one of our customers want's to have a link to the privacy protecti...When adding a description to protected external content only plaintext inside data-consent-description attribute is possible at the moment. The data protection officer of one of our customers want's to have a link to the privacy protection information of an external tool inside this description. Would it be possible to add this feature?5.0.0https://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/230Add data-nosnippet to Cookiebanner div2022-09-08T10:29:37ZOliver KrammerAdd data-nosnippet to Cookiebanner divPrevent that the Cookiebanner text will shown at Google search results
https://developers.google.com/search/docs/advanced/robots/robots_meta_tag?hl=de#data-nosnippet-attrPrevent that the Cookiebanner text will shown at Google search results
https://developers.google.com/search/docs/advanced/robots/robots_meta_tag?hl=de#data-nosnippet-attr5.0.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/226Google Lighthouse test says "tabindex" in templates is an accessibility issue2022-10-03T21:15:10ZTobi WollenderGoogle Lighthouse test says "tabindex" in templates is an accessibility issueWhen testing a website with sg_cookie_optin through https://web.dev we get the following errors for the cookie-banner (in the accessibility section):
`Some elements have a [tabindex] value greater than 0`
According https://web.dev/tabi...When testing a website with sg_cookie_optin through https://web.dev we get the following errors for the cookie-banner (in the accessibility section):
`Some elements have a [tabindex] value greater than 0`
According https://web.dev/tabindex/ it says
`Although technically valid, using a tabindex greater than 0 is considered an anti-pattern because it shifts the affected element to the end of the tab order. This unexpected behavior can make it seem like some elements can't be accessed via keyboard, which is frustrating for users who rely on assistive technologies.`
So maybe you can optimize this5.0.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/224Different base domain for localized website (CORS)2022-08-29T14:53:55ZSebastian KleinDifferent base domain for localized website (CORS)We have a single tree setup with two languages and `fallbackType: strict`.
- The default language uses the base URL **www.domain.de** (sys_language_uid=0)
- The localized website uses the differing base URL **www.domain.com** (sys_langua...We have a single tree setup with two languages and `fallbackType: strict`.
- The default language uses the base URL **www.domain.de** (sys_language_uid=0)
- The localized website uses the differing base URL **www.domain.com** (sys_language_uid=1)
Problem: The frontend assets of sg_cookie_optin are always rendered using the **default** base domain. This leads to CORS policy issues for the localized website.
> Access to script at 'https://www.domain.de/fileadmin/sg_cookie_optin/siteroot-1/cookieOptin.js?1657792279' from origin 'https://www.domain.com' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.
Can this issue be solved with the current configuration options or must the extension be extended to support different domains for localizations?
- TYPO3 11.5.13
- PHP 8.0.17
- sg_cookie_optin 4.5.04.6.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/223Test PHP 8.1 compatibilty and officially support it2022-08-29T15:33:29ZGeorgiTest PHP 8.1 compatibilty and officially support it4.6.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/205Fingerprint icon like User centrics to open the popup2022-09-12T10:49:07ZStefan Galinskistefan@sgalinski.deFingerprint icon like User centrics to open the popup![image](/uploads/d728b2a57992a172485d781084d93927/image.png)
- Possible to define the place (bottom/top left/right).
- Opens the consent
- Only visible if not opened
- Color and tooltip definable![image](/uploads/d728b2a57992a172485d781084d93927/image.png)
- Possible to define the place (bottom/top left/right).
- Opens the consent
- Only visible if not opened
- Color and tooltip definable5.0.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/204New file name for CSS/JS2022-12-12T05:07:42ZStefan Galinskistefan@sgalinski.deNew file name for CSS/JS![image](/uploads/f6a0bb66e75544e39a086f42c97346c3/image.png)
Include a hash inside the filename to allow proper preloading and caching. The query cache buster can be removed then.![image](/uploads/f6a0bb66e75544e39a086f42c97346c3/image.png)
Include a hash inside the filename to allow proper preloading and caching. The query cache buster can be removed then.5.0.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/193wrong path in cookie-optin data json for subsites2022-03-25T14:04:56Zkaroline steinfattwrong path in cookie-optin data json for subsitesWe have a site (example.com) that has several country sub-sites as separate trees as a country directory under the main domain.
main site:
base: 'https://www.example.com/'
country site (separate tree with own site root):
base: 'https:...We have a site (example.com) that has several country sub-sites as separate trees as a country directory under the main domain.
main site:
base: 'https://www.example.com/'
country site (separate tree with own site root):
base: 'https://www.example.com/it'
We need the cookie banner for some of those country sites, but the backend generates the path to the assets like this:
**cookieOptinData--it_IT.UTF-8--0.json**:
`loadingJavaScript": "https:\/\/www.example.com\/it\/fileadmin\/sg_cookie_optin\/siteroot-272\/analytics-0.js`
How can we get rid of the prefix in the path?4.4.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/190External Content - Special implementation YouTube/Vimeo2022-10-21T08:57:56ZStefan Galinskistefan@sgalinski.deExternal Content - Special implementation YouTube/VimeoAnd for Youtube it would be good to have an integrated function that saves the thumbnails locally and you can then use them in the content window. Like Nicole does with her extension social_gdpr (https://github.com/IchHabRecht/social_gdpr).And for Youtube it would be good to have an integrated function that saves the thumbnails locally and you can then use them in the content window. Like Nicole does with her extension social_gdpr (https://github.com/IchHabRecht/social_gdpr).5.0.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/189Enhance Look & Feel of the External Content Layer2022-10-03T21:16:32ZStefan Galinskistefan@sgalinski.deEnhance Look & Feel of the External Content LayerIt would be cool if you could not only give the consent for the external content depending on the service, but then also customize the templates individually. So that you can make e.g. uncomplicated for Youtube another Consent window tha...It would be cool if you could not only give the consent for the external content depending on the service, but then also customize the templates individually. So that you can make e.g. uncomplicated for Youtube another Consent window than for Google Maps (with special icons/background graphics/texts etc.).5.0.0GeorgiGeorgi