sg_cookie_optin issueshttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues2023-08-08T19:37:00Zhttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/254Change banner_button_accept_essential_text to TEXT2023-08-08T19:37:00ZGeorgiChange banner_button_accept_essential_text to TEXTWe added this in 5.1.0 because of the default valueWe added this in 5.1.0 because of the default value5.3.0https://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/280Field 'template_html' doesn't have a default value2023-08-08T19:36:49ZStefan Galinskistefan@sgalinski.deField 'template_html' doesn't have a default valueAll text fields must be changed to this:
![image](/uploads/573a514b206d9f32de0d107aa700d085/image.png)
---
I’m having another issue with this plugin. After trying to duplicate the configuration across the site roots using the import/e...All text fields must be changed to this:
![image](/uploads/573a514b206d9f32de0d107aa700d085/image.png)
---
I’m having another issue with this plugin. After trying to duplicate the configuration across the site roots using the import/export function. I get the following error.
An exception occurred while executing 'INSERT INTO `tx_sgcookieoptin_domain_model_optin` (`pid`, `description`, `banner_description`, `essential_description`, `iframe_description`, `iframe_button_load_one_description`, `cookiebanner_whitelist_regex`, `domains_to_delete_cookies_for`, `overwrite_baseurl`, `accept_all_text`, `accept_specific_text`, `accept_essential_text`, `extend_box_link_text`, `extend_box_link_text_close`, `extend_table_link_text`, `extend_table_link_text_close`, `cookie_name_text`, `cookie_provider_text`, `cookie_purpose_text`, `cookie_lifetime_text`, `save_confirmation_text`, `user_hash_text`, `banner_button_accept_text`, `banner_button_settings_text`, `essential_title`, `iframe_title`, `iframe_button_allow_all_text`, `iframe_button_allow_one_text`, `iframe_button_load_one_text`, `iframe_open_settings_text`, `iframe_replacement_background_image`) VALUES(?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)' with params [109, "Auf unserer Webseite werden Cookies verwendet. Einige davon werden zwingend ben\u00f6tigt, w\u00e4hrend es uns andere erm\u00f6glichen, Ihre Nutzererfahrung auf unserer Webseite zu verbessern.", "Auf unserer Webseite werden Cookies verwendet. Einige davon werden zwingend ben\u00f6tigt, w\u00e4hrend es uns andere erm\u00f6glichen, Ihre Nutzererfahrung auf unserer Webseite zu verbessern.", "Essenzielle Cookies werden f\u00fcr grundlegende Funktionen der Webseite ben\u00f6tigt. Dadurch ist gew\u00e4hrleistet, dass die Webseite einwandfrei funktioniert.", "Wir verwenden auf unserer Website externe Inhalte, um Ihnen zus\u00e4tzliche Informationen anzubieten.", "", "", "", "", "Alle akzeptieren", "Speichern & schlie\u00dfen", "Nur essenzielle Cookies akzeptieren", "Weitere Informationen anzeigen", "Weitere Informationen verstecken", "Cookie-Informationen anzeigen", "Cookie-Informationen verstecken", "Name", "Anbieter", "Zweck", "Laufzeit", "Cookie-Einstellungen erfolgreich gespeichert", "User-Hash", "Akzeptieren", "Einstellungen", "Essenziell", "Externe Inhalte", "Alle externen Inhalte erlauben", "Einmalig erlauben", "Externen Inhalt laden", "Einstellungen anzeigen", ""]: Field 'template_html' doesn't have a default value5.3.0https://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/279iframe not blocked in TYPO3 12 if only essential cookies are accepted if ifra...2023-08-08T19:15:46ZFabian Schilleriframe not blocked in TYPO3 12 if only essential cookies are accepted if iframeWhitelist is emptyTYPO3 v12.4.3
sgalinski/sg-cookie-optin v.5.2.4
If only the essential cookies are accepted, iframes are still loading and not blocked away like in previous versions. Block external content is enabled in backend (iframe_enabled=1)
Cook...TYPO3 v12.4.3
sgalinski/sg-cookie-optin v.5.2.4
If only the essential cookies are accepted, iframes are still loading and not blocked away like in previous versions. Block external content is enabled in backend (iframe_enabled=1)
Cookie Value: essential:1|preferences:0|analytics:0|marketing:0|iframes:0
As you can see in the screenshot, even if the user hasn't accepted anything, the YouTube iframe is still loading in the background.
![Bildschirm_foto_2023-07-20_um_11.42.22](/uploads/d98ae1bcdfbd51f6fb02430ddd7644ba/Bildschirm_foto_2023-07-20_um_11.42.22.png)
The release of this project is next week on monday. Is there any possible workaround or hope for a quickfix?
Thanks in advance!5.3.0https://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/261The fingerprint icon is not consistent across all web browsers and all platforms2023-08-03T12:13:01ZGeorgiThe fingerprint icon is not consistent across all web browsers and all platforms6.0.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/277Whitelisting of external iFrame content not working if ".*" is used (maybe al...2023-06-17T11:40:14ZThomas JiraskoWhitelisting of external iFrame content not working if ".*" is used (maybe also other syntax)Hi,
in the following website, I cannot get the whitelisting of a specific iFrame external content to work.
Here, I integrated a job widget: https://www.systeno.de/karriere
This is my config in the corresponding textarea "Externe Inhal...Hi,
in the following website, I cannot get the whitelisting of a specific iFrame external content to work.
Here, I integrated a job widget: https://www.systeno.de/karriere
This is my config in the corresponding textarea "Externe Inhalte whitelisten" in tab "Externe Inhalte"
```
^https:\/\/www\.google\.com\/recaptcha\/
^https:\/\/gwh\.jobbase\.io\/.*
^https:\/\/gwh\.onlyfy\.jobs\/.*
```
Why is the iFrame still blocked?
TYPO3: 11.5.25
sg_cookie_optin: 5.2.2
Regards TJhttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/266iFrame Replacement Template Code - Missing Default Template2023-05-24T12:46:04ZStefan Galinskistefan@sgalinski.deiFrame Replacement Template Code - Missing Default Templateseen in TYPO3 10
... currently it can be fetched manually from the tab before.seen in TYPO3 10
... currently it can be fetched manually from the tab before.5.2.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/262Undefined array key warning if extension is installed and not properly set up2023-05-18T10:51:25ZKarsten NowakUndefined array key warning if extension is installed and not properly set upI installed sgalinski-cookie-optin with composer on my local docker machine. If no Extension configuration is done after install, the Arrey key
`$GLOBALS['TYPO3_CONF_VARS']['EXTENSIONS']['sg_cookie_optin']` does not exists. I use TYPO3 1...I installed sgalinski-cookie-optin with composer on my local docker machine. If no Extension configuration is done after install, the Arrey key
`$GLOBALS['TYPO3_CONF_VARS']['EXTENSIONS']['sg_cookie_optin']` does not exists. I use TYPO3 11.5.24 and PHP 8.1. I configuration set once then is ok.
For the moment I patched line 62 in `sg_cookie_optin/Classes/Service/ExtensionSettingsService.php`
`$configuration = $GLOBALS['TYPO3_CONF_VARS']['EXTENSIONS']['sg_cookie_optin'] ?? '';`
That helps.5.2.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/264> 2: SQL error: 'Field 'iframe_warning' doesn't have a default value'2023-05-18T10:51:02ZStefan Galinskistefan@sgalinski.de> 2: SQL error: 'Field 'iframe_warning' doesn't have a default value'This might be the MySQL Strict mode again. At least this issue should be fixed. Also test for further errors with MySQL Strict that we can fix.This might be the MySQL Strict mode again. At least this issue should be fixed. Also test for further errors with MySQL Strict that we can fix.5.2.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/265PHP Runtime Deprecation Notice: trim(): Passing null to parameter #1 ($string...2023-05-18T10:50:43ZStefan Galinskistefan@sgalinski.dePHP Runtime Deprecation Notice: trim(): Passing null to parameter #1 ($string) of type string is deprecatedwe are using a licensed version of sg_cookie_optin in our Typo3. I just wanted to report a bug, but I didn’t want to sign in to your gitlab.
There is a problem with the newest version when using PHP 8.1, I fixed the problem on my own...we are using a licensed version of sg_cookie_optin in our Typo3. I just wanted to report a bug, but I didn’t want to sign in to your gitlab.
There is a problem with the newest version when using PHP 8.1, I fixed the problem on my own now.
TYPO3-Version 11.5.24
PHP-Version 8.1.13
Error: PHP Runtime Deprecation Notice: trim(): Passing null to parameter #1 ($string) of type string is deprecated in XXX/typo3conf/ext/sg_cookie_optin/Contrib/mustache/src/Mustache/Tokenizer.php line 109
File: /typo3conf/ext/sg_cookie_optin/Contrib/mustache/src/Mustache/Tokenizer.php
Line: 109
Problem: No Json configuration is written (and the consent wil not be displayerd)
OLD:
if ($delimiters = trim($delimiters)) {
$this->setDelimiters($delimiters);
}
NEW (FIX):
if ($delimiters && $delimiters = trim($delimiters)) {
$this->setDelimiters($delimiters);
}
Hope that helps!5.2.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/260Set a fixed width to the SVG graphics2023-02-09T13:34:58ZGeorgiSet a fixed width to the SVG graphics![image](/uploads/ae70e5d149698955b65a6494ecfd47a4/image.png)
otherwise this happens![image](/uploads/ae70e5d149698955b65a6494ecfd47a4/image.png)
otherwise this happens5.1.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/250Fingerprint doesn't respect the dark mode setting2023-02-09T13:34:31ZGeorgiFingerprint doesn't respect the dark mode setting5.1.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/249Do not show Fingerprint in test mode2023-02-09T13:34:31ZGeorgiDo not show Fingerprint in test modeThis breaks the test mode functionalityThis breaks the test mode functionality5.1.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/258Enforce exact matching to the cookie name regex2023-02-07T19:41:30ZGeorgiEnforce exact matching to the cookie name regex5.1.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/259Fingerprint must open the cookie optin settings directly and not the banner w...2023-02-07T19:40:58ZGeorgiFingerprint must open the cookie optin settings directly and not the banner when the banner has been enabled5.1.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/237overwrite_baseurl produces invalid js url2022-12-13T11:47:47ZHenrikoverwrite_baseurl produces invalid js urlsetting a value for overwrite_baseurl (for example https://mydomain.de) produces an invalid URL for the JavaScript-Include, CSS is working as expected.
generated CSS-Code (`Classes/UserFunction/AddCookieOptinJsAndCss.php` at line 110)
`...setting a value for overwrite_baseurl (for example https://mydomain.de) produces an invalid URL for the JavaScript-Include, CSS is working as expected.
generated CSS-Code (`Classes/UserFunction/AddCookieOptinJsAndCss.php` at line 110)
```html
<link rel="preload" as="style" href="https://mydomain.de/fileadmin/sg_cookie_optin/siteroot-1/cookieOptin.css?1663159745" media="all" crossorigin="anonymous">
<link rel="stylesheet" href="https://mydomain.de/fileadmin/sg_cookie_optin/siteroot-1/cookieOptin.css?1663159745" media="all" crossorigin="anonymous">
```
generated JS-Code (`Classes/UserFunction/AddCookieOptinJsAndCss.php` at line 162)
```html
<link rel="preload" as="script" href="https://mydomain.de/" data-ignore="1" crossorigin="anonymous">
<script src="https://mydomain.de/" data-ignore="1" crossorigin="anonymous"></script>
```5.0.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/241Filter for values saved into tx_sgcookieoptin_domain_model_user_preference (i...2022-10-03T21:10:19ZManuel MunzFilter for values saved into tx_sgcookieoptin_domain_model_user_preference (item_identifier column)So it seems someone tried to do SQL injections at one instance where we use the plugin (current 4.6.0 version) via the tx_sgcookieoptin_domain_model_user_preference table.
```
SELECT DISTINCT item_identifier FROM tx_sgcookieoptin_domain...So it seems someone tried to do SQL injections at one instance where we use the plugin (current 4.6.0 version) via the tx_sgcookieoptin_domain_model_user_preference table.
```
SELECT DISTINCT item_identifier FROM tx_sgcookieoptin_domain_model_user_preference;
essential
marketing
statistiken
-1 OR OR 2+205-205-1=0+0+0+1
-1 OR 2+210-210-1=0+0+0+1 --
[hundreds more]
```
In the backend module for statistics then a pie chart is created for every value of item_identifier:
![image](/uploads/5e6f28e18b6d9267fd40ee8ee4e28753/image.jpg)
Note: The first graph is probably for item_identifier = '', not sure if this should ever happen.
A possible solution could be to filter for valid 'Service groups' before inserting them in OptinHistoryService.php5.0.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/236Fix PHP 7.0 issues2022-09-09T12:29:40ZGeorgiFix PHP 7.0 issuesThere are still some public const in TemplateService left and possibly in other placesThere are still some public const in TemplateService left and possibly in other places5.0.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/211activationScriptFile / save_history_webhook doesn't respect overwrite_base_url2022-08-29T14:54:35ZGeorgiactivationScriptFile / save_history_webhook doesn't respect overwrite_base_urlIt must be fixed in the StaticFileGenerationService
This also counts for the "save_history_webhook" setting that must also respect the base URL setting.It must be fixed in the StaticFileGenerationService
This also counts for the "save_history_webhook" setting that must also respect the base URL setting.4.6.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/229EXTERNAL_CONTENT_ELEMENT_SELECTOR improperly used2022-08-29T14:34:01ZGeorgiEXTERNAL_CONTENT_ELEMENT_SELECTOR improperly usedThere is a bug in cookieOptin.js where the constant EXTERNAL_CONTENT_ELEMENT_SELECTOR is not used properlyThere is a bug in cookieOptin.js where the constant EXTERNAL_CONTENT_ELEMENT_SELECTOR is not used properly4.6.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/213Statistics error2022-08-29T14:30:56ZTodea GeorgeStatistics errorHello,
I've updated the extension to latest 4.4.4 and when I try to access Statistics in BE, I get "syntax error, unexpected '='".
Please see attached screenshot.
![sg_cookie-error](/uploads/7da646256c7e8eeafa1d52577f139811/sg_cookie-...Hello,
I've updated the extension to latest 4.4.4 and when I try to access Statistics in BE, I get "syntax error, unexpected '='".
Please see attached screenshot.
![sg_cookie-error](/uploads/7da646256c7e8eeafa1d52577f139811/sg_cookie-error.png)
Thank you4.6.0