sg_cookie_optin issueshttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues2021-01-17T20:35:21Zhttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/139Footer links not working for translated pages in TYPO3 7.62021-01-17T20:35:21ZKarsten NowakFooter links not working for translated pages in TYPO3 7.6TYPO3 7.6.49, sgalinski Cookie Optin 3.2.8, translated cookieoptin data with link to translated data privacy page.
It doesn't matter realurl is activated or not. I've tried `config.absRefPRefix = auto` and `= /`. No baseUrl is set.
Aft...TYPO3 7.6.49, sgalinski Cookie Optin 3.2.8, translated cookieoptin data with link to translated data privacy page.
It doesn't matter realurl is activated or not. I've tried `config.absRefPRefix = auto` and `= /`. No baseUrl is set.
After saving cookie optin data the links on translated cookie optin are just a link to the homepage with added parameter `?disableOptIn=1`.3.3.0https://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/40Accessibility Tab Keys2020-12-15T13:56:08ZStefan Galinskistefan@sgalinski.deAccessibility Tab KeysYou have to press the Tab key until the very end to edit the dialog, because the tab index is not explicitly set, if necessary you could set the tab index to -1?You have to press the Tab key until the very end to edit the dialog, because the tab index is not explicitly set, if necessary you could set the tab index to -1?3.3.0https://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/137Don't show a blank page if no site route was found2020-11-21T13:44:04ZStefan Galinskistefan@sgalinski.deDon't show a blank page if no site route was found3.3.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/135Disable the "Powered by" via a checkbox is not working if cookie banner is op...2020-10-07T19:17:24ZThomas JiraskoDisable the "Powered by" via a checkbox is not working if cookie banner is opened by show configuartion (Einstellungen anzeigen)The disable the "Powered by" via a checkbox is not working if the cookie banner is opened by the link "show configuartion" (Einstellungen anzeigen) of a blocked external content element.The disable the "Powered by" via a checkbox is not working if the cookie banner is opened by the link "show configuartion" (Einstellungen anzeigen) of a blocked external content element.3.3.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/102Problems with Subdirectory Installations2020-09-30T18:09:30ZStefan Galinskistefan@sgalinski.deProblems with Subdirectory InstallationsSubdirectory installation (like mydomain.de/somedirectory/fileadmin/...) don't work with the recent version of the cookie optin extension. The path in fileadmin can be changed to fix the issue, but it would be better if this is handled a...Subdirectory installation (like mydomain.de/somedirectory/fileadmin/...) don't work with the recent version of the cookie optin extension. The path in fileadmin can be changed to fix the issue, but it would be better if this is handled automatically. Also the saving of the configuration is only working if the path is calculated correctly.3.2.0https://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/7The option "..." in the backend modules are not working.2020-09-25T12:49:30ZStefan Galinskistefan@sgalinski.deThe option "..." in the backend modules are not working.3.3.0https://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/41Contrast ratio2020-09-24T21:35:04ZStefan Galinskistefan@sgalinski.deContrast ratioContrast ratio of the default colors is not optimal (but can be changed in the settings).![2769184E-8DA6-479F-9A12-9B30FE880948_fritz](/uploads/759cce7598607f7ce70b14e27529de3f/2769184E-8DA6-479F-9A12-9B30FE880948_fritz.jpg)Contrast ratio of the default colors is not optimal (but can be changed in the settings).![2769184E-8DA6-479F-9A12-9B30FE880948_fritz](/uploads/759cce7598607f7ce70b14e27529de3f/2769184E-8DA6-479F-9A12-9B30FE880948_fritz.jpg)3.3.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/72External content via iframe does not get inserted in the right place after ac...2020-09-15T08:15:28ZUwe MichelfelderExternal content via iframe does not get inserted in the right place after acceptingIt accours that an iframe which gets loaded after the click on the accept button is inserted on the wrong spot.
Example can be seen here:
https://www.transparency.de/index.php?id=426It accours that an iframe which gets loaded after the click on the accept button is inserted on the wrong spot.
Example can be seen here:
https://www.transparency.de/index.php?id=4263.2.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/66Include a configurable whitelist of external content (like for invisible reca...2020-08-25T13:59:08ZStefan Galinskistefan@sgalinski.deInclude a configurable whitelist of external content (like for invisible recaptcha)We should define a global whitelist in general e.g. for recaptcha.We should define a global whitelist in general e.g. for recaptcha.3.2.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/55External Content Protection not working always2020-08-19T12:02:57ZStefan Galinskistefan@sgalinski.deExternal Content Protection not working alwaysExample: Demo site (demo.sgalinski.de) / demo page
All YouTube videos are rendered, because the MutationObserver is not working here. Seems like it must also check childs. Even by doing this, I couldn't get it working. See some test cod...Example: Demo site (demo.sgalinski.de) / demo page
All YouTube videos are rendered, because the MutationObserver is not working here. Seems like it must also check childs. Even by doing this, I couldn't get it working. See some test code. This is extremely slow. You can see it also here: https://www.benediktbeuern.de/wandertouren
```
// Create an observer instance linked to the callback function
iFrameObserver = new MutationObserver(function(mutationsList, observer) {
// Use traditional 'for loops' for IE 11
for (var index in mutationsList) {
var mutation = mutationsList[index];
if (mutation.type !== 'childList' || mutation.addedNodes.length <= 0) {
continue;
}
for (var addedNodeIndex in mutation.addedNodes) {
var addedNode = mutation.addedNodes[addedNodeIndex];
if (addedNode.children.length > 0) {
for (var childIndex in addedNode.children) {
var childNode = addedNode.children[childIndex];
if (childNode.children.length > 0) {
for (var childIndex2 in childNode.children) {
var childNode2 = childNode.children[childIndex2];
if (childNode2.children.length > 0) {
for (var childIndex3 in childNode2.children) {
var childNode3 = childNode2.children[childIndex3];
if (childNode3.children.length > 0) {
for (var childIndex4 in childNode3.children) {
var childNode4 = childNode3.children[childIndex4];
if (childNode4.tagName === 'IFRAME') {
replaceIFrameWithConsent(childNode4);
}
}
} else if (childNode3.tagName === 'IFRAME') {
replaceIFrameWithConsent(childNode3);
}
}
} else if (childNode2.tagName === 'IFRAME') {
replaceIFrameWithConsent(childNode2);
}
}
} else if (childNode.tagName === 'IFRAME') {
replaceIFrameWithConsent(childNode);
}
}
} else if (addedNode.tagName === 'IFRAME') {
replaceIFrameWithConsent(addedNode);
}
}
}
});
// Start observing the target node for configured mutations
iFrameObserver.observe(document, {subtree: true, childList: true});
}
```3.2.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/122[BUG] clickEventHandler in Selection Modal2020-08-13T06:50:26ZChristian Richter[BUG] clickEventHandler in Selection ModalI'm currently implementing the cookie optin for a client of mine who is willing to buy one or two lifetime licences, but we found a little bug, which he finds very inconvenient and prevents us from going to production and make the purcha...I'm currently implementing the cookie optin for a client of mine who is willing to buy one or two lifetime licences, but we found a little bug, which he finds very inconvenient and prevents us from going to production and make the purchase.
When (for whatever reason) the first page call goes directly to the privacy page, where the Content Element is included, the selection checkboxes in the modal trigger the content elements checkboxes. I think the behaviour is logical and hope it can be fixed. (video is attached)
Otherwise I really like the plugin and am going to suggest this solution to all of my clients!
![optin-click-bug](/uploads/347af1690987a8ee9ab3510d9d15e259/optin-click-bug.mp4)3.2.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/82Weird rendering with external content protection2020-08-13T01:10:45ZStefan Galinskistefan@sgalinski.deWeird rendering with external content protectionhttps://www.benediktbeuern.de/wetter-webcam/
![image](/uploads/12870da09ea0523889d3a4e181d8a361/image.png)https://www.benediktbeuern.de/wetter-webcam/
![image](/uploads/12870da09ea0523889d3a4e181d8a361/image.png)3.2.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/114TYPO3 9+ - no chash generation for footer links (the parameter doesn't change...2020-08-13T01:10:30ZStefan Galinskistefan@sgalinski.deTYPO3 9+ - no chash generation for footer links (the parameter doesn't changes page content!)This prevents the parameter from being added to the canonical and hreflang.This prevents the parameter from being added to the canonical and hreflang.3.2.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/115[BUG] GenerateFilesAfterTcaSave::getLanguages() won't respect SiteConfigurati...2020-08-13T01:10:09ZtheLine[BUG] GenerateFilesAfterTcaSave::getLanguages() won't respect SiteConfiguration (TYPO3 v9)Since TYPO3 v9 introduced `SiteConfiguration` it's possible to enable various languages for different trees.
Now when a language is missing from a tree, that's available in an other tree `GenerateFilesAfterTcaSave` will try to generate ...Since TYPO3 v9 introduced `SiteConfiguration` it's possible to enable various languages for different trees.
Now when a language is missing from a tree, that's available in an other tree `GenerateFilesAfterTcaSave` will try to generate static files for non-available languages and throw an Exception.
My proposed solution:
Use `SiteFinder` to fetch available Languages instead of all languages.
Unfortunately I'm unable to fork this Project to create a Merge Request, so here's a patch file: [bugfix-115.diff](/uploads/0d67f865bef3d56f97d7bbb010eb1542/bugfix-115.diff)3.2.0GeorgiGeorgihttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/111After update to 3.1.,1 exception: cannot declare class..." on activating othe...2020-05-15T18:53:27ZKarsten NowakAfter update to 3.1.,1 exception: cannot declare class..." on activating other extension in backendI update sg_cookie_optin to v3.1.1 yesterday with composer update.
Today I want to activate another extension in extensions manager. On activating this extension the backend is broken with following exception:
`Cannot declare class SgC...I update sg_cookie_optin to v3.1.1 yesterday with composer update.
Today I want to activate another extension in extensions manager. On activating this extension the backend is broken with following exception:
`Cannot declare class SgCookieAbstractViewHelper, because the name is already in use`
If I downgrade sg_cookie_optin to 3.0.0 everything is fine. I can activate and deactivate those extension.3.2.0https://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/110Url of footer links broken, realurl not respected2020-05-15T18:52:57ZKarsten NowakUrl of footer links broken, realurl not respectedIn version 3.x of sg_cookie_optin and TYPO3 8.7, the links in footer section of cookie box are broken if we use realurl for links. The saved url in json files for the language looks like this:
`?id=124&disableOptin=1&L=1`
Now the link ...In version 3.x of sg_cookie_optin and TYPO3 8.7, the links in footer section of cookie box are broken if we use realurl for links. The saved url in json files for the language looks like this:
`?id=124&disableOptin=1&L=1`
Now the link in cookie box becomes an href attribute with exactly this link. We don't use a base url. The generated url is just appended to the current page url. Which results in this url:
`https://www.mydomain/en/my-page/?id=124&disableOptin=1&L=1`
That won't work. I'm not sure whether the problem is in our configuration or not. Has nobody here a similar problem? I can't found an issue for this topic ;-).
I found this line
`$url = $contentObject->getTypoLink_URL($uid, '&disableOptIn=1&L=' . $languageUid);`
in `sg_cookie_optin/Classes/Hook/GenerateFilesAfterTcaSave.php` file. But I'm not sure that is the problem. Maybe the TYPO3 version or realurl version or my realurl configuration.I have a TYPO3 instance 7.6 with sg_cookie_optin 2.x and there are no problems with the urls of the footer-links
Any idea? Can anybody reproduce this error?
For the moment I patched the `sg_cookie_optin/Classes/Hook/GenerateFilesAfterTcaSave.php` and prepending the url with a `/`. But for sure, that's just a dirty workaround to fix the problem temporarly.3.2.0https://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/112Backend Module is hidden after installation2020-05-15T18:45:55ZTim WagnerBackend Module is hidden after installationhttps://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/106Pipe next to "Powered by" is inluded in the link in the larger template2020-05-08T17:12:03ZTim WagnerPipe next to "Powered by" is inluded in the link in the larger template![image](/uploads/6c010ca7365075ab1a63fad7a497bd57/image.png)![image](/uploads/6c010ca7365075ab1a63fad7a497bd57/image.png)3.1.0https://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/104Compact Layout - Link to open cookie information not changed after click2020-05-08T17:12:03ZStefan Galinskistefan@sgalinski.deCompact Layout - Link to open cookie information not changed after clickThe wrong text is shown for the expanded cookie information (for single groups).The wrong text is shown for the expanded cookie information (for single groups).3.1.0https://gitlab.sgalinski.de/typo3/sg_cookie_optin/-/issues/96The Files aren't generated and the backend is loaded in the same frame after ...2020-04-08T16:54:56ZFabian GalinskiThe Files aren't generated and the backend is loaded in the same frame after saving.There is already a fix for this. See this commit: https://gitlab.sgalinski.de/typo3/sg_cookie_optin
Steps to do:
- Check all TYPO3 versions.
- Check the multilanguage behaviour, if it's still working.There is already a fix for this. See this commit: https://gitlab.sgalinski.de/typo3/sg_cookie_optin
Steps to do:
- Check all TYPO3 versions.
- Check the multilanguage behaviour, if it's still working.3.0.2Fabian GalinskiFabian Galinski