xliff 1.2 does not allow a generator
tag in the header and also no author.
Simon Schaufelberger (5ec2fb0c) at 14 Feb 16:05
Merge branch 'php-cs-fixer' into 'master'
... and 3 more commits
Thank you! That was the most radical change of my upcoming changes. All the following are minor improvements from now on.
Simon Schaufelberger (489063fa) at 14 Feb 16:01
I have updated my merge request to conform to your ecs standards but still improve the code style here and there which isn't covered by ecs.
Would that be ok to merge?
Simon Schaufelberger (489063fa) at 14 Feb 15:48
[TASK] Format code according to Easy Coding Standards and PHP CS Fixer
ok, thanx for sharing.
I find it strange that you added:
'control_structures_opening_brace' => CurlyBracesPositionFixer::SAME_LINE,
'functions_opening_brace' => CurlyBracesPositionFixer::SAME_LINE,
'anonymous_functions_opening_brace' => CurlyBracesPositionFixer::SAME_LINE,
'classes_opening_brace' => CurlyBracesPositionFixer::SAME_LINE,
as this goes totally against any PSR standard
ok but if your coding styles are only internal, how can other contributors follow your coding standards?
I'm also curious about your release workflow as you don't publish a distribution zip but just tag a commit and nothing more. The big downside of this is that people need to download the whole repo vi composer in the background instead of just a dist which would be the case for github for example. I know that with a gitlab pipeline you can also do that in your own installation.
Simon Schaufelberger (e56b4e1d) at 13 Feb 19:51
I know this is quite a radical one but I'm open to hear your feedback about this one! Especially about the location of the php cs fixer config file location. Maybe you prefer to have this in the root? I talked with Stefan Bürk and he said he likes it in the Build
folder.
Executed commands:
Simon Schaufelberger (cc30a4ee) at 13 Feb 19:22
[TASK] Format code according to TYPO3 Coding Standards
Simon Schaufelberger (e56b4e1d) at 13 Feb 19:02
[TASK] List all required TYPO3 extensions and PHP extensions in com...
Simon Schaufelberger (7c782c54) at 13 Feb 18:56
Merge branch 'add-basic-extension-files' into 'master'
... and 3 more commits
Simon Schaufelberger (3e649181) at 13 Feb 12:52
I totally understand but in this case it assures that even when you checkout the extension standalone and work on it, you can make use of these files.
Simon Schaufelberger (adb1a592) at 13 Feb 11:58
Simon Schaufelberger (3e649181) at 12 Feb 23:26
[TASK] Add .editorconfig, .gitattributes and .phpstorm.meta.php and...